Implement the get option.

Author: Aleksi Salmela

src/main/java/fi/helsinki/cs/tmc/cli/command/ConfigCommand.java

@@ -26,12 +26,16 @@ public class ConfigCommand extends AbstractCommand {
 
     @Override
     public String[] getUsages() {
-        return new String[] {"[-q|--quiet] KEY=\"VALUE\"...", "-d [-q|--quiet] KEY...", "-l"};
+        return new String[] {
+            "[-q|--quiet] KEY=\"VALUE\"...",
+            "-d|--delete [-q|--quiet] KEY...",
+            "-l|--list",
+            "-g|--get=KEY"};
     }
 
     @Override
     public void getOptions(Options options) {
-        options.addOption("g", "get", false, "Get value of a key");
+        options.addOption("g", "get", true, "Get value of a key");
         options.addOption("d", "delete", false, "Unset given property keys");
         options.addOption("q", "quiet", false, "Don't ask confirmations");
         options.addOption("l", "list", false, "List all properties");
@@ -60,13 +64,28 @@ public void run(CliContext context, CommandLine args) {
         if (listing) {
             if (arguments.length != 0) {
                 io.errorln("Listing option doesn't take any arguments.");
+                printUsage(context);
                 return;
             }
             printAllProperties();
             return;
         }
 
-        if (delete) {
+        if(get) {
+            if (arguments.length != 0) {
+                io.errorln("There should not be extra arguments when using --get option.");
+                printUsage(context);
+                return;
+            }
+            String key = args.getOptionValue('g');
+            boolean exists = properties.containsKey(key);
+            if (!exists && !quiet) {
+                io.errorln("The property " + key + " doesn't exist.");
+                return;
+            }
+            io.println(exists ? properties.get(key) : "");
+            return;
+        } else if (delete) {
             deleteProperties(arguments);
         } else {
             setProperties(arguments);
@@ -113,7 +132,7 @@ private void deleteProperties(String[] keys) {
         }
         for (String key : keys) {
             String oldValue = properties.remove(key);
-            io.println("Unset key " + key + ", was " + oldValue);
+            io.println("Deleted key " + key + ", was " + oldValue);
         }
     }
 

src/test/java/fi/helsinki/cs/tmc/cli/command/ConfigCommandTest.java

@@ -39,13 +39,13 @@ public void printsErrorIfNoArgumentsGiven() {
 
     @Test
     public void printsErrorIfTwoConflictingOptionsGiven() {
-        app.run(new String[] {"config", "--get", "--list"});
+        app.run(new String[] {"config", "--delete", "--list"});
         io.assertContains("Only one of the");
     }
 
     @Test
     public void printsErrorIfThreeConflictingOptionsGiven() {
-        app.run(new String[] {"config", "--get", "--list", "--delete"});
+        app.run(new String[] {"config", "--delete", "--list", "--get", "property"});
         io.assertContains("Only one of the");
     }
 
@@ -58,6 +58,43 @@ public void listsAllProperties() {
         io.assertContains("toilet=wonderland");
     }
 
+    @Test
+    public void listsAllPropertiesWithExtraArgument() {
+        props.put("hello", "world");
+        props.put("toilet", "wonderland");
+        app.run(new String[] {"config", "--list", "abc"});
+        io.assertContains("Listing option doesn't take any arguments.");
+    }
+
+    @Test
+    public void getProperty() {
+        props.put("thing", "value");
+        app.run(new String[] {"config", "--get", "thing"});
+        io.assertContains("value");
+        io.assertAllPromptsUsed();
+    }
+
+    @Test
+    public void getUnexistingProperty() {
+        app.run(new String[] {"config", "--get", "thing"});
+        io.assertContains("The property thing doesn't exist");
+        io.assertAllPromptsUsed();
+    }
+
+    @Test
+    public void getUnexistingPropertyQuietly() {
+        app.run(new String[] {"config", "--get", "-q", "thing"});
+        io.assertNotContains("The property thing doesn't exist");
+        io.assertAllPromptsUsed();
+    }
+
+    @Test
+    public void getPropertyWithExtraArgument() {
+        props.put("thing", "value");
+        app.run(new String[] {"config", "--get", "thing", "abc"});
+        io.assertContains("There should not be extra arguments when using --get option.");
+    }
+
     @Test
     public void setsOnePropertyWhenNoOptionsGiven() {
         io.addConfirmationPrompt(true);
@@ -122,6 +159,25 @@ public void deletesOnePropertyQuietly() {
         io.assertAllPromptsUsed();
     }
 
+    @Test
+    public void deletesInvalidProperty() {
+        app.run(new String[] {"config", "-d", "property"});
+        assertTrue(!props.containsKey("no"));
+        io.assertContains("Key property doesn't exist.");
+        io.assertAllPromptsUsed();
+    }
+
+    @Test
+    public void deletesOnePropertyWithNoConfirmation() {
+        io.addConfirmationPrompt(false);
+        props.put("no", "e");
+        app.run(new String[] {"config", "-d", "no"});
+        assertTrue(props.containsKey("no"));
+        io.assertContains("Deleting 1 properties.");
+        io.assertNotContains("Deleted key no, was");
+        io.assertAllPromptsUsed();
+    }
+
     @Test
     public void deletesMultiplePropertiesCorrectly() {
         io.addConfirmationPrompt(true);