Skip to content

Commit 141b3c2

Browse files
committed
Make setting jdkhome more reliable
1 parent 26be11f commit 141b3c2

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

tmc-langs-java/src/main/java/fi/helsinki/cs/tmc/langs/java/maven/MavenInvokatorMavenTaskRunner.java

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,19 @@ public MavenExecutionResult exec(Path projectPath, String[] mavenArgs) {
4343

4444
InvocationRequest request = new DefaultInvocationRequest();
4545
request.setMavenOpts(MAVEN_OPTS);
46-
String jdkhome = System.getenv("jdkhome");
47-
Path jdkhomePath = Paths.get(jdkhome);
48-
if (jdkhome != null && jdkhome.length() > 0 && Files.exists(jdkhomePath)) {
49-
request.setJavaHome(jdkhomePath.toFile());
46+
try {
47+
String jdkhome = System.getenv("jdkhome");
48+
if (jdkhome != null) {
49+
Path jdkhomePath = Paths.get(jdkhome);
50+
if (jdkhome != null && jdkhome.length() > 0 && Files.exists(jdkhomePath)) {
51+
request.setJavaHome(jdkhomePath.toFile());
52+
}
53+
}
54+
} catch (Exception e) {
55+
log.debug("jdkhome variable not valid, skipping", e);
5056
}
5157

58+
5259
String mavenHome = System.getenv("M3_HOME");
5360
if (mavenHome == null) {
5461
mavenHome = System.getenv("M2_HOME");
@@ -77,22 +84,14 @@ public MavenExecutionResult exec(Path projectPath, String[] mavenArgs) {
7784
request.setPomFile(projectPath.resolve("pom.xml").toFile());
7885
request.setBaseDirectory(projectPath.toFile());
7986
request.setOutputHandler(
80-
new InvocationOutputHandler() {
81-
82-
@Override
83-
public void consumeLine(String line) {
84-
log.info("MavenInvokator: {}", line);
85-
out.println(line);
86-
}
87+
line -> {
88+
log.info("MavenInvokator: {}", line);
89+
out.println(line);
8790
});
8891
request.setErrorHandler(
89-
new InvocationOutputHandler() {
90-
91-
@Override
92-
public void consumeLine(String line) {
93-
log.info("MavenInvokator: {}", line);
94-
err.println(line);
95-
}
92+
line -> {
93+
log.info("MavenInvokator: {}", line);
94+
err.println(line);
9695
});
9796

9897
request.setGoals(Arrays.asList(mavenArgs));

0 commit comments

Comments
 (0)