Skip to content

Commit da105b7

Browse files
committed
Fix NPE during tests caused by null exception message
1 parent 596e0c8 commit da105b7

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

tmc-langs-java/src/main/java/fi/helsinki/cs/tmc/langs/java/TestResultParser.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,9 @@ private TestResult convertTestCaseResult(fi.helsinki.cs.tmc.testrunner.TestCase
7777
List<String> points = new ArrayList<>();
7878

7979
if (testCase.exception != null) {
80-
exception.add(testCase.exception.message);
80+
if (testCase.exception.message != null) {
81+
exception.add(testCase.exception.message);
82+
}
8183
for (StackTraceElement stackTrace : testCase.exception.stackTrace) {
8284
exception.add(stackTrace.toString());
8385
}

tmc-langs-java/src/test/java/fi/helsinki/cs/tmc/langs/java/maven/MavenPluginTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ public void testMultipleTestMethodsGetAddedToRunResultWhenSomeFail() {
189189

190190
assertTrue(result.testResults.get(0).getException().isEmpty());
191191
assertFalse(
192-
"Lol:" + result.testResults.get(1).getException(),
192+
"Expected not empty, was:" + result.testResults.get(1).getException(),
193193
result.testResults.get(1).getException().isEmpty());
194194
}
195195

0 commit comments

Comments
 (0)