Skip to content

Commit 053e382

Browse files
committed
Fix thread leaking
1 parent 6d27ae5 commit 053e382

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

build.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
<target name="-check-mavenmodules">
1212
<uptodate property="mavenmodules.uptodate"
13-
srcfile="maven-wrapper/target/nbm/maven-wrapper-1.14.nbm"
13+
srcfile="maven-wrapper/target/nbm/maven-wrapper-1.15.nbm"
1414
targetfile="mavenmodules"/>
1515
</target>
1616

maven-wrapper/pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>fi.helsinki.cs.tmc</groupId>
66
<artifactId>maven-wrapper</artifactId>
7-
<version>1.14</version>
7+
<version>1.15</version>
88
<packaging>nbm</packaging>
99

1010
<name>TMC Maven Wrapper</name>
@@ -46,7 +46,7 @@
4646
<dependency>
4747
<groupId>${project.groupId}</groupId>
4848
<artifactId>core</artifactId>
49-
<version>0.9.12-SNAPSHOT</version>
49+
<version>0.9.13-SNAPSHOT</version>
5050
</dependency>
5151
<dependency>
5252
<groupId>${project.groupId}</groupId>
@@ -105,12 +105,12 @@
105105
<dependency>
106106
<groupId>org.cometd.java</groupId>
107107
<artifactId>cometd-java-client</artifactId>
108-
<version>3.0.3</version>
108+
<version>3.1.2</version>
109109
</dependency>
110110
<dependency>
111111
<groupId>org.cometd.java</groupId>
112112
<artifactId>cometd-java-websocket-javax-client</artifactId>
113-
<version>3.0.3</version>
113+
<version>3.1.2</version>
114114
</dependency>
115115
<dependency>
116116
<groupId>org.slf4j</groupId>
@@ -121,7 +121,7 @@
121121
<dependency>
122122
<groupId>org.eclipse.jetty.websocket</groupId>
123123
<artifactId>javax-websocket-client-impl</artifactId>
124-
<version>9.2.5.v20141112</version>
124+
<version>9.4.6.v20170531</version>
125125
</dependency>
126126

127127
</dependencies>

tmc-plugin/src/fi/helsinki/cs/tmc/actions/TmcModuleInstall.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ public void run() {
5252
CheckForNewExercisesOrUpdates.startTimer();
5353
CheckForNewReviews.startTimer();
5454
ReviewEventListener.start();
55-
PushEventListener.start();
55+
// Push events are disabled for now since this spams threads and
56+
// its functionality is rarely used since code reviews trigger
57+
// an email notification.
58+
// PushEventListener.start();
5659
TmcSettings settings = TmcSettingsHolder.get();
5760
SpywareFacade.start();
5861

0 commit comments

Comments
 (0)