Skip to content

Commit 2f17e66

Browse files
committed
More cleanup
1 parent 65fd8a9 commit 2f17e66

File tree

5 files changed

+43
-38
lines changed

5 files changed

+43
-38
lines changed

tmc-plugin/src/fi/helsinki/cs/tmc/events/TmcEventBus.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class TmcEventBus {
1616
public static TmcEventBus getDefault() {
1717
return instance;
1818
}
19-
19+
2020
// Factory method to avoid accidental creation when getDefault was meant.
2121
public static TmcEventBus createNewInstance() {
2222
return new TmcEventBus();
@@ -28,22 +28,22 @@ public static TmcEventBus createNewInstance() {
2828
private static interface Wrapper {
2929
public boolean wraps(TmcEventListener that);
3030
}
31-
31+
3232
private static class WeakListener extends TmcEventListener implements Wrapper {
3333
private WeakReference<TmcEventListener> weakRef;
34-
34+
3535
public WeakListener(TmcEventListener listener) {
3636
this.weakRef = new WeakReference<TmcEventListener>(listener);
3737
}
38-
38+
3939
@Override
4040
public void receive(TmcEvent event) throws Throwable {
4141
TmcEventListener listener = weakRef.get();
4242
if (listener != null) {
4343
listener.receive(event);
4444
}
4545
}
46-
46+
4747
@Override
4848
public boolean mayBeUnsubscribed() {
4949
return weakRef.get() == null;
@@ -54,16 +54,16 @@ public boolean wraps(TmcEventListener that) {
5454
return that == weakRef.get();
5555
}
5656
}
57-
57+
5858
private static class DependentListener extends TmcEventListener implements Wrapper {
5959
private TmcEventListener listener;
6060
private WeakReference<Object> weakRef;
61-
61+
6262
public DependentListener(TmcEventListener listener, Object dependency) {
6363
this.listener = listener;
6464
this.weakRef = new WeakReference<Object>(dependency);
6565
}
66-
66+
6767
@Override
6868
public void receive(TmcEvent event) throws Throwable {
6969
listener.receive(event);
@@ -91,15 +91,15 @@ private TmcEventBus() {
9191
public synchronized void subscribeStrongly(TmcEventListener listener) {
9292
this.listeners.add(listener);
9393
}
94-
94+
9595
/**
9696
* Subscribes a weak reference to a listener.
9797
* After all normal references to the listener disappear, it will eventually be unsubscribed.
9898
*/
9999
public synchronized void subscribeWeakly(TmcEventListener listener) {
100100
this.listeners.add(new WeakListener(listener));
101101
}
102-
102+
103103
/**
104104
* Subscribes a listener that is eventually removed after a given dependency is garbage-collected.
105105
*/
@@ -125,7 +125,7 @@ public synchronized void post(TmcEvent event) {
125125
eventQueue.add(event);
126126
processEventQueue();
127127
}
128-
128+
129129
private void processEventQueue() {
130130
// This handles post() during post()
131131
// but not yet subscribe*() during post().
@@ -146,4 +146,4 @@ private void processEventQueue() {
146146
}
147147
}
148148
}
149-
}
149+
}

tmc-plugin/src/fi/helsinki/cs/tmc/events/TmcEventListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ public void receive(TmcEvent event) throws Throwable {
3333
}
3434
}
3535
}
36-
36+
3737
/**
3838
* Whether this listener may be unsubscribed at any point by the event bus.
3939
*/
4040
public boolean mayBeUnsubscribed() {
4141
return false;
4242
}
43-
}
43+
}

tmc-plugin/src/fi/helsinki/cs/tmc/exerciseSubmitter/ExerciseSubmitter.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package fi.helsinki.cs.tmc.exerciseSubmitter;
22

3-
import com.google.common.base.Strings;
4-
import com.google.common.util.concurrent.ListenableFuture;
53
import fi.helsinki.cs.tmc.actions.CheckForNewExercisesOrUpdates;
64
import fi.helsinki.cs.tmc.actions.ServerErrorHelper;
75
import fi.helsinki.cs.tmc.actions.SubmitExerciseAction;
@@ -22,11 +20,15 @@
2220
import fi.helsinki.cs.tmc.utilities.BgTask;
2321
import fi.helsinki.cs.tmc.utilities.BgTaskListener;
2422
import fi.helsinki.cs.tmc.utilities.CancellableCallable;
25-
import java.util.logging.Level;
26-
import java.util.logging.Logger;
23+
24+
import com.google.common.base.Strings;
25+
import com.google.common.util.concurrent.ListenableFuture;
2726

2827
import org.netbeans.api.project.Project;
2928

29+
import java.util.logging.Level;
30+
import java.util.logging.Logger;
31+
3032
public class ExerciseSubmitter {
3133

3234
private static final Logger log = Logger.getLogger(SubmitExerciseAction.class.getName());

tmc-plugin/src/fi/helsinki/cs/tmc/layergen/UpdateCenterLayerGen.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,25 @@
44
import fi.helsinki.cs.tmc.tailoring.Tailoring;
55
import fi.helsinki.cs.tmc.utilities.urlcallback.CallbackURLStreamHandler;
66
import fi.helsinki.cs.tmc.utilities.urlcallback.URLCallback;
7+
8+
import org.openide.filesystems.Repository;
9+
import org.openide.filesystems.Repository.LayerProvider;
10+
import org.openide.util.lookup.ServiceProvider;
11+
712
import java.io.ByteArrayInputStream;
813
import java.io.InputStream;
914
import java.io.UnsupportedEncodingException;
1015
import java.net.MalformedURLException;
1116
import java.net.URL;
1217
import java.util.Collection;
13-
import org.openide.filesystems.Repository;
14-
import org.openide.filesystems.Repository.LayerProvider;
15-
import org.openide.util.lookup.ServiceProvider;
1618

1719
/**
1820
* Generates an update center instance based on the selected tailoring.
1921
*/
2022
@ServiceProvider(service=LayerProvider.class)
2123
public class UpdateCenterLayerGen extends Repository.LayerProvider {
2224
private static final String CALLBACK_NAME = "/" + UpdateCenterLayerGen.class.getCanonicalName();
23-
25+
2426
private static URLCallback callback = new URLCallback() {
2527
@Override
2628
public String getInputEncoding() {
@@ -36,9 +38,9 @@ public InputStream openInputStream() {
3638
}
3739
}
3840
};
39-
41+
4042
private static boolean callbackRegistered = false;
41-
43+
4244
public UpdateCenterLayerGen() {
4345
synchronized (UpdateCenterLayerGen.class) {
4446
if (!callbackRegistered) {
@@ -47,7 +49,7 @@ public UpdateCenterLayerGen() {
4749
callbackRegistered = true;
4850
}
4951
}
50-
52+
5153
@Override
5254
protected void registerLayers(Collection<? super URL> layers) {
5355
try {
@@ -56,10 +58,10 @@ protected void registerLayers(Collection<? super URL> layers) {
5658
throw new RuntimeException(ex);
5759
}
5860
}
59-
61+
6062
private static String getInstanceXML() {
6163
Tailoring tailoring = SelectedTailoring.get();
62-
64+
6365
return
6466
"<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" +
6567
"<!DOCTYPE filesystem PUBLIC \"-//NetBeans//DTD Filesystem 1.2//EN\" \"http://www.netbeans.org/dtds/filesystem-1_2.dtd\">\n" +
@@ -77,4 +79,4 @@ private static String getInstanceXML() {
7779
" </folder>\n" +
7880
"</filesystem>";
7981
}
80-
}
82+
}
Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,25 @@
11
package fi.helsinki.cs.tmc.model;
22

3+
import org.openide.filesystems.FileObject;
4+
import org.openide.filesystems.FileUtil;
5+
36
import java.io.BufferedInputStream;
47
import java.io.BufferedOutputStream;
58
import java.io.IOException;
69
import java.io.InputStreamReader;
710
import java.io.OutputStreamWriter;
811
import java.io.Reader;
912
import java.io.Writer;
10-
import org.openide.filesystems.FileObject;
11-
import org.openide.filesystems.FileUtil;
1213

1314
public class ConfigFile {
14-
15+
1516
private final String name;
1617
private FileObject fileObject;
17-
18+
1819
public ConfigFile(String name) {
1920
this.name = name;
2021
}
21-
22+
2223
public FileObject getFileObject() throws IOException {
2324
if (fileObject == null) {
2425
FileObject root = FileUtil.getConfigRoot();
@@ -33,19 +34,19 @@ public FileObject getFileObject() throws IOException {
3334
}
3435
return fileObject;
3536
}
36-
37+
3738
public boolean exists() throws IOException {
3839
return getFileObject().getSize() > 0;
3940
}
4041

4142
public Writer getWriter() throws IOException {
4243
return new OutputStreamWriter(new BufferedOutputStream(getFileObject().getOutputStream()), "UTF-8");
4344
}
44-
45+
4546
public Reader getReader() throws IOException {
4647
return new InputStreamReader(new BufferedInputStream(getFileObject().getInputStream()), "UTF-8");
4748
}
48-
49+
4950
public void writeContents(String s) throws IOException {
5051
Writer w = getWriter();
5152
try {
@@ -54,8 +55,8 @@ public void writeContents(String s) throws IOException {
5455
w.close();
5556
}
5657
}
57-
58+
5859
public String readContents() throws IOException {
5960
return getFileObject().asText("UTF-8");
6061
}
61-
}
62+
}

0 commit comments

Comments
 (0)