Skip to content

Commit 4307d34

Browse files
a544jhjamo
authored andcommitted
added functional test
1 parent 71c6e61 commit 4307d34

File tree

3 files changed

+31
-3
lines changed

3 files changed

+31
-3
lines changed

tmc-plugin/src/fi/helsinki/cs/tmc/ui/PreferencesUIFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public void showPreferencesDialog(final ActionListener dialogListener) {
8585
ActionListener closeListener = new ActionListener() {
8686
@Override
8787
public void actionPerformed(ActionEvent e) {
88-
destroyDialog();
88+
forgetDialog();
8989
dialogListener.actionPerformed(e);
9090
}
9191
};
@@ -101,7 +101,7 @@ public void actionPerformed(ActionEvent e) {
101101
dialog.addWindowListener(new WindowAdapter() {
102102
@Override
103103
public void windowClosed(WindowEvent we) {
104-
destroyDialog();
104+
forgetDialog();
105105
}
106106
});
107107
SwingUtilities.invokeLater(new Runnable() {
@@ -112,7 +112,7 @@ public void run() {
112112
});
113113
}
114114

115-
private void destroyDialog() {
115+
private void forgetDialog() {
116116
panel = null;
117117
dialog = null;
118118
}
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
2+
package fi.helsinki.cs.tmc.functionaltests;
3+
4+
import fi.helsinki.cs.tmc.functionaltests.utils.SettingsOperator;
5+
import fi.helsinki.cs.tmc.functionaltests.utils.TmcFunctionalTestCase;
6+
import static fi.helsinki.cs.tmc.functionaltests.utils.TmcFunctionalTestCase.loadSuite;
7+
import junit.framework.Test;
8+
9+
public class ClosingSettingsDialogTest extends TmcFunctionalTestCase{
10+
public static Test suite() {
11+
return loadSuite(ClosingSettingsDialogTest.class);
12+
}
13+
14+
public ClosingSettingsDialogTest() {
15+
super("ClosingSettingsDialogTest");
16+
}
17+
18+
19+
public void testClosingSettingsDialog() throws Exception {
20+
SettingsOperator settings = SettingsOperator.openSettingsDialog();
21+
settings.closeDialogWindow();
22+
settings = SettingsOperator.openSettingsDialog();
23+
}
24+
}

tmc-plugin/test/qa-functional/src/fi/helsinki/cs/tmc/functionaltests/utils/SettingsOperator.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ public void clickCancel() {
7373
new JButtonOperator(dialog, "Cancel").doClick();
7474
}
7575

76+
public void closeDialogWindow(){
77+
dialog.close();
78+
}
79+
7680
public void setProjectDownloadDirToTestWorkDir(NbTestCase testCase) throws IOException {
7781
// doClick blocks waiting for the file chooser so we send it to the background
7882
SwingUtilities.invokeLater(new Runnable() {

0 commit comments

Comments
 (0)