TestRunResult Status changed to compilationSucceeded boolean

Author: puny

tmc-plugin/src/fi/helsinki/cs/tmc/data/TestRunResult.java

@@ -4,30 +4,29 @@
 import java.util.List;
 
 public class TestRunResult {
-    public static enum Status {
-        PASSED,
-        COMPILE_FAILED
-    }
-    
     private final List<TestCaseResult> testCaseResults;
-    public final Status status;
+    private final boolean compilationSucceeded;
 
     public TestRunResult(List<TestCaseResult> testCaseResults) {
-        this.status = Status.PASSED;
+        this.compilationSucceeded = true;
         this.testCaseResults = testCaseResults;
     }
 
-    public TestRunResult(Status status) {
-        this.status = status;
+    public TestRunResult(boolean compilationSucceeded) {
+        this.compilationSucceeded = compilationSucceeded;
         this.testCaseResults = new ArrayList<TestCaseResult>();
     }
 
-    public TestRunResult(List<TestCaseResult> testCaseResults, Status status) {
+    public TestRunResult(List<TestCaseResult> testCaseResults, boolean compilationSucceeded) {
         this.testCaseResults = testCaseResults;
-        this.status = status;
+        this.compilationSucceeded = compilationSucceeded;
     }
 
     public List<TestCaseResult> getTestCaseResults() {
         return testCaseResults;
     }
+    
+    public boolean getCompilationSuccess() {
+        return compilationSucceeded;
+    }
 }

tmc-plugin/src/fi/helsinki/cs/tmc/runners/AntExerciseRunner.java

@@ -2,7 +2,6 @@
 
 import fi.helsinki.cs.tmc.data.Exercise;
 import fi.helsinki.cs.tmc.data.TestRunResult;
-import fi.helsinki.cs.tmc.data.TestRunResult.Status;
 import fi.helsinki.cs.tmc.model.TmcProjectInfo;
 import fi.helsinki.cs.tmc.model.UserVisibleException;
 import fi.helsinki.cs.tmc.testscanner.TestMethod;
@@ -43,7 +42,7 @@ public TestRunResult call() throws Exception {
                     log.log(Level.INFO, "Compile success for project {0}", projectInfo.toString());
                     return runTests(projectInfo);
                 } else {
-                    return new TestRunResult(Status.COMPILE_FAILED);
+                    return new TestRunResult(false);
                 }
             }
         };

tmc-plugin/src/fi/helsinki/cs/tmc/runners/MakefileExerciseRunner.java

@@ -2,7 +2,6 @@
 
 import fi.helsinki.cs.tmc.data.Exercise;
 import fi.helsinki.cs.tmc.data.TestRunResult;
-import fi.helsinki.cs.tmc.data.TestRunResult.Status;
 import fi.helsinki.cs.tmc.model.TmcProjectInfo;
 import fi.helsinki.cs.tmc.model.UserVisibleException;
 import fi.helsinki.cs.tmc.utilities.process.ProcessResult;
@@ -49,7 +48,7 @@ public TestRunResult call() throws Exception {
                     if (ret != 0) {
                         io.select();
                         log.log(Level.INFO, "Compile resulted in non-zero exit code {0}", result.statusCode);
-                        return new TestRunResult(Status.COMPILE_FAILED);
+                        return new TestRunResult(false);
                     }
 
                     log.info("Running tests");

tmc-plugin/src/fi/helsinki/cs/tmc/runners/MavenExerciseRunner.java

@@ -2,7 +2,6 @@
 
 import fi.helsinki.cs.tmc.data.Exercise;
 import fi.helsinki.cs.tmc.data.TestRunResult;
-import fi.helsinki.cs.tmc.data.TestRunResult.Status;
 import fi.helsinki.cs.tmc.model.TmcProjectInfo;
 import fi.helsinki.cs.tmc.utilities.maven.MavenRunBuilder;
 import fi.helsinki.cs.tmc.utilities.process.ProcessResult;
@@ -47,7 +46,7 @@ public TestRunResult call() throws Exception {
                     if (ret != 0) {
                         inOut.select();
                         log.log(Level.INFO, "Compile resulted in non-zero exit code {0}", result.statusCode);
-                        return new TestRunResult(Status.COMPILE_FAILED);
+                        return new TestRunResult(false);
                     } else {
                         log.log(Level.INFO, "Running tests");
                         return runTests(projectInfo, inOut);

tmc-plugin/src/fi/helsinki/cs/tmc/runners/TestRunHandler.java

@@ -60,7 +60,7 @@ public void performAction(final ResultCollector resultCollector, Project... proj
             BgTask.start("Running tests", runner.getTestRunningTask(projectInfo), new BgTaskListener<TestRunResult>() {
                 @Override
                 public void bgTaskReady(TestRunResult result) {
-                    if (result.status == TestRunResult.Status.COMPILE_FAILED) {
+                    if (!result.getCompilationSuccess()) {
                         dialogDisplayer.displayError("The code did not compile.");
                         return;
                     }