Skip to content

Commit 85cda09

Browse files
committed
Updating to tmc-core with paths
1 parent 7347ee3 commit 85cda09

File tree

8 files changed

+20
-13
lines changed

8 files changed

+20
-13
lines changed

tmc-plugin/src/fi/helsinki/cs/tmc/actions/CheckForNewExercisesOrUpdates.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import fi.helsinki.cs.tmc.core.exceptions.TmcCoreException;
2121
import java.awt.event.ActionEvent;
2222
import java.awt.event.ActionListener;
23+
import java.net.URI;
2324
import java.util.ArrayList;
2425
import javax.swing.AbstractAction;
2526
import javax.swing.Icon;
@@ -96,10 +97,9 @@ public void run() {
9697
}
9798
}
9899

99-
private String detailUrl(final Course currentCourseBeforeUpdate) {
100-
return new ServerAccess().addApiCallQueryParameters(
101-
currentCourseBeforeUpdate.getDetailsUrl()
102-
);
100+
private URI detailUrl(final Course currentCourseBeforeUpdate) {
101+
return URI.create(new ServerAccess().addApiCallQueryParameters(
102+
currentCourseBeforeUpdate.getDetailsUrl()));
103103
}
104104

105105
/**

tmc-plugin/src/fi/helsinki/cs/tmc/actions/PastebinAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ private void submitPaste(final TmcProjectInfo projectInfo, final Exercise exerci
108108
projectMediator.saveAllFiles();
109109
final String errorMsgLocale = settings.getErrorMsgLocale().toString();
110110
try {
111-
ListenableFuture<URI> result = TmcCoreSingleton.getInstance().pasteWithComment(projectInfo.getProjectDirAbsPath(), messageForReviewer);
111+
ListenableFuture<URI> result = TmcCoreSingleton.getInstance().pasteWithComment(projectInfo.getProjectDirAsPath(), messageForReviewer);
112112
Futures.addCallback(result, new PasteResult());
113113
} catch (TmcCoreException ex) {
114114
Exceptions.printStackTrace(ex);

tmc-plugin/src/fi/helsinki/cs/tmc/actions/RefreshCoursesAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public void onSuccess(final List<Course> courses) {
125125
createSystemHandle("Loading course");
126126
loadingCourse.start();
127127
ListenableFuture<Course> courseFuture = tmcCore.getCourse(
128-
currentCourse.getDetailsUrl()
128+
currentCourse.getDetailsUrlAsUri()
129129
);
130130
Futures.addCallback(courseFuture, new UpdateCourse(courses, loadingCourse));
131131
} catch (TmcCoreException ex) {

tmc-plugin/src/fi/helsinki/cs/tmc/actions/SendFeedbackAction.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import fi.helsinki.cs.tmc.core.domain.submission.SubmissionResult;
1515
import fi.helsinki.cs.tmc.core.exceptions.TmcCoreException;
1616
import java.io.IOException;
17+
import java.net.URI;
1718
import java.util.HashMap;
1819
import java.util.List;
1920
import java.util.Map;
@@ -41,13 +42,11 @@ public void run() {
4142
try {
4243
ListenableFuture<HttpResult> feedbackFuture;
4344
feedbackFuture = core.sendFeedback(
44-
getFeedbackAnswers(), result.getFeedbackAnswerUrl()
45+
getFeedbackAnswers(), URI.create(result.getFeedbackAnswerUrl())
4546
);
4647
Futures.addCallback(feedbackFuture, new FeedbackReplyCallback());
4748
} catch (TmcCoreException ex) {
4849
Exceptions.printStackTrace(ex);
49-
} catch (IOException ex) {
50-
Exceptions.printStackTrace(ex);
5150
}
5251
}
5352

tmc-plugin/src/fi/helsinki/cs/tmc/actions/SubmitExerciseAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ private void submitProject(TmcProjectInfo info) {
8383
final SubmissionResultWaitingDialog dialog = SubmissionResultWaitingDialog.createAndShow();
8484
try {
8585
ListenableFuture<SubmissionResult> result;
86-
result = core.submit(info.getProjectDirAbsPath());
86+
result = core.submit(info.getProjectDirAsPath());
8787
Futures.addCallback(result, new SubmissionCallback(exercise, dialog));
8888
} catch (TmcCoreException ex) {
8989
String message = "There was an error submitting project " + info.getProjectName();

tmc-plugin/src/fi/helsinki/cs/tmc/model/TmcProjectInfo.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import fi.helsinki.cs.tmc.utilities.zip.RecursiveZipper;
44
import java.io.File;
5+
import java.nio.file.Path;
6+
import java.nio.file.Paths;
57
import java.util.regex.Pattern;
68
import org.netbeans.api.project.Project;
79
import org.netbeans.api.project.ProjectUtils;
@@ -35,7 +37,11 @@ public FileObject getProjectDir() {
3537
public File getProjectDirAsFile() {
3638
return FileUtil.toFile(getProjectDir());
3739
}
38-
40+
41+
public Path getProjectDirAsPath() {
42+
return Paths.get(getProjectDirAbsPath());
43+
}
44+
3945
public String getProjectDirAbsPath() {
4046
return FileUtil.toFile(getProjectDir()).getAbsolutePath();
4147
}

tmc-plugin/src/fi/helsinki/cs/tmc/runners/CheckstyleRunHandler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import fi.helsinki.cs.tmc.stylerunner.validation.Strategy;
1515
import fi.helsinki.cs.tmc.stylerunner.validation.ValidationError;
1616
import java.io.File;
17+
import java.nio.file.Paths;
1718
import java.util.HashMap;
1819
import java.util.List;
1920
import java.util.Map;
@@ -37,7 +38,7 @@ public void performAction(final ResultCollector resultCollector, final Project p
3738
ProjectMediator.getInstance().saveAllFiles();
3839

3940
try {
40-
ListenableFuture<ValidationResult> result = TmcCoreSingleton.getInstance().runCheckstyle(projectInfo.getProjectDirAsFile().getAbsolutePath());
41+
ListenableFuture<ValidationResult> result = TmcCoreSingleton.getInstance().runCheckstyle(projectInfo.getProjectDirAsPath());
4142
Futures.addCallback(result, new ExplainValidationResult(resultCollector, dialogDisplayer));
4243

4344
} catch (TmcCoreException ex) {

tmc-plugin/src/fi/helsinki/cs/tmc/runners/TestRunHandler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import fi.helsinki.cs.tmc.ui.ConvenientDialogDisplayer;
2525
import fi.helsinki.cs.tmc.ui.TestResultDisplayer;
2626
import fi.helsinki.cs.tmc.core.exceptions.TmcCoreException;
27+
import java.nio.file.Paths;
2728
import java.util.ArrayList;
2829
import java.util.List;
2930
import static java.util.logging.Level.INFO;
@@ -72,7 +73,7 @@ public void performAction(final ResultCollector resultCollector, Project... proj
7273
"Running tests.");
7374
runningTestsLocally.start();
7475
try {
75-
ListenableFuture<RunResult> result = TmcCoreSingleton.getInstance().test(projectInfo.getProjectDirAbsPath());
76+
ListenableFuture<RunResult> result = TmcCoreSingleton.getInstance().test(projectInfo.getProjectDirAsPath());
7677
Futures.addCallback(result, new FutureCallback<RunResult>() {
7778
@Override
7879
public void onSuccess(final RunResult result) {

0 commit comments

Comments
 (0)