Skip to content

Commit c775b35

Browse files
author
Joni Salmi
committed
Code review request enabling refactor and support for older servers
1 parent 0a64f26 commit c775b35

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

tmc-plugin/src/fi/helsinki/cs/tmc/actions/RequestReviewAction.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -69,19 +69,8 @@ protected CourseDb getCourseDb() {
6969
}
7070

7171
@Override
72-
public boolean enable(Project... projects) {
73-
if (projects.length != 1) {
74-
return false; // One at a time please
75-
}
76-
77-
TmcProjectInfo projectInfo = projectMediator.wrapProject(projects[0]);
78-
Exercise exercise = projectMediator.tryGetExerciseForProject(projectInfo, courseDb);
79-
80-
if (exercise != null && !exercise.isCodeReviewRequestsEnabled()) {
81-
return false;
82-
}
83-
84-
return super.enable(projects);
72+
protected boolean enabledFor(Exercise exercise) {
73+
return exercise.isCodeReviewRequestsEnabled() && super.enabledFor(exercise);
8574
}
8675

8776
@Override

tmc-plugin/src/fi/helsinki/cs/tmc/data/Exercise.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public class Exercise implements Serializable {
5858
private ValgrindStrategy valgrindStrategy = ValgrindStrategy.FAIL;
5959

6060
@SerializedName("code_review_requests_enabled")
61-
private boolean codeReviewRequestsEnabled;
61+
private boolean codeReviewRequestsEnabled = true;
6262

6363
public enum ValgrindStrategy {
6464
@SerializedName("")

0 commit comments

Comments
 (0)