Fix exercise downloading and updating dialog

Author: OAarne

tmc-plugin/src/fi/helsinki/cs/tmc/actions/CheckForNewExercisesOrUpdates.java

@@ -12,8 +12,8 @@
 import fi.helsinki.cs.tmc.core.events.TmcEventBus;
 import fi.helsinki.cs.tmc.model.CourseDb;
 import fi.helsinki.cs.tmc.model.LocalExerciseStatus;
-import fi.helsinki.cs.tmc.ui.DownloadOrUpdateExercisesDialog;
 import fi.helsinki.cs.tmc.ui.ConvenientDialogDisplayer;
+import fi.helsinki.cs.tmc.ui.DownloadOrUpdateExercisesDialog;
 import fi.helsinki.cs.tmc.ui.TmcNotificationDisplayer;
 import fi.helsinki.cs.tmc.utilities.BgTask;
 import fi.helsinki.cs.tmc.utilities.BgTaskListener;

tmc-plugin/src/fi/helsinki/cs/tmc/actions/DownloadCompletedExercises.java

@@ -32,9 +32,9 @@
 @Messages("CTL_DownloadCompletedExercises=Download old completed exercises")
 public final class DownloadCompletedExercises implements ActionListener {
 
-    private CourseDb courseDb;
-    private ConvenientDialogDisplayer dialogs;
-    private TmcEventBus eventBus;
+    private final CourseDb courseDb;
+    private final ConvenientDialogDisplayer dialogs;
+    private final TmcEventBus eventBus;
 
     public DownloadCompletedExercises() {
         this.courseDb = CourseDb.getInstance();

tmc-plugin/src/fi/helsinki/cs/tmc/actions/SaveSettingsAction.java

@@ -19,12 +19,12 @@
 
 public class SaveSettingsAction extends AbstractAction {
 
-    private CourseDb courseDb;
-    private TmcEventBus eventBus;
-    private TmcCore tmcCore;
+    private final CourseDb courseDb;
+    private final TmcEventBus eventBus;
+    private final TmcCore tmcCore;
     private final FixUnoptimalSettings fixUnoptimalSettings;
-    private SendDiagnostics sendDiagnostics;
-    
+    private final SendDiagnostics sendDiagnostics;
+
     public SaveSettingsAction() {
         this.courseDb = CourseDb.getInstance();
         this.eventBus = TmcEventBus.getDefault();

tmc-plugin/src/fi/helsinki/cs/tmc/model/LocalExerciseStatus.java

@@ -24,12 +24,12 @@ public static LocalExerciseStatus get(List<Exercise> allExercises) {
     }
 
     private LocalExerciseStatus(CourseDb courseDb, ProjectMediator projectMediator, List<Exercise> allExercises) {
-        open = new ArrayList<Exercise>();
-        closed = new ArrayList<Exercise>();
-        downloadableUncompleted = new ArrayList<Exercise>();
-        downloadableCompleted = new ArrayList<Exercise>();
-        updateable = new ArrayList<Exercise>();
-        unlockable = new ArrayList<Exercise>();
+        open = new ArrayList<>();
+        closed = new ArrayList<>();
+        downloadableUncompleted = new ArrayList<>();
+        downloadableCompleted = new ArrayList<>();
+        updateable = new ArrayList<>();
+        unlockable = new ArrayList<>();
 
         for (Exercise ex : allExercises) {
             if (!ex.hasDeadlinePassed()) {