Add support for extra app data

Author: nygrenh

app/controllers/api/v8/users_controller.rb

@@ -69,6 +69,82 @@ def show
           administrator: user.administrator
         )
       end
+
+      def create
+        authorize! :create, User
+
+        @user = User.new
+
+        @user.login = params[:user][:username].to_s.strip
+
+        set_email
+        set_password
+        set_user_fields
+        set_extra_data
+
+        if @user.errors.empty? && @user.save
+          UserMailer.email_confirmation(@user).deliver_now
+          render json: {
+            success: true,
+            message: 'User created.'
+          }
+        else
+          render json: {
+            success: false,
+            errors: @user.errors
+          }
+        end
+      end
+
+      private
+
+      def set_email
+        user_params = params[:user]
+
+        return if !@user.new_record? && user_params[:email_confirmation].blank?
+
+        if user_params[:email].blank?
+          @user.errors.add(:email, 'needed')
+        elsif user_params[:email] != user_params[:email_confirmation]
+          @user.errors.add(:email_confirmation, 'did not match')
+        else
+          @user.email = user_params[:email].strip
+        end
+      end
+
+      def set_password
+        user_params = params[:user]
+        if user_params[:password].blank?
+          @user.errors.add(:password, 'needed')
+        elsif user_params[:password] != user_params[:password_confirmation]
+          @user.errors.add(:password_confirmation, 'did not match')
+        else
+          @user.password = user_params[:password]
+        end
+      end
+
+      def set_user_fields
+        return if params[:user_field].nil?
+        changes = {}
+        UserField.all.select { |f| f.visible_to?(current_user) }.each do |field|
+          value_record = @user.field_value_record(field)
+          old_value = value_record.ruby_value
+          value_record.set_from_form(params[:user_field][field.name])
+          new_value = value_record.ruby_value
+          changes[field.name] = { from: old_value, to: new_value } unless new_value == old_value
+        end
+        changes
+      end
+
+      def set_extra_data
+        extra_fields = params['user']['extra_fields']
+        return if extra_fields.nil?
+        namespace = extra_fields['namespace']
+        raise "Namespace not defined" unless namespace
+        extra_fields['data'].each do |record|
+          @user.user_app_data.new(namespace: namespace, field_name: record['field_name'], value: record[:value])
+        end
+      end
     end
   end
 end

app/models/user.rb

@@ -16,6 +16,7 @@ class User < ActiveRecord::Base
   has_many :awarded_points, dependent: :delete_all
   has_many :action_tokens, dependent: :delete_all
   has_many :user_field_values, dependent: :delete_all, autosave: true
+  has_many :user_app_data, dependent: :delete_all, autosave: true
   has_many :unlocks, dependent: :delete_all
   has_many :uncomputed_unlocks, dependent: :delete_all
   has_many :reviews, foreign_key: :reviewer_id, inverse_of: :reviewer, dependent: :nullify

app/models/user_app_datum.rb

@@ -0,0 +1,3 @@
+class UserAppDatum < ActiveRecord::Base
+  belongs_to :user
+end

config/routes.rb

@@ -42,7 +42,7 @@
     namespace :v8, defaults: {format: 'json'} do
       resources :apidocs, only: :index, path: 'documentation'
 
-      resources :users, only: :show
+      resources :users, only: [:show, :create]
 
       resources :organizations, param: :slug, path: 'org', only: %i{index show} do
         resources :courses, module: :organizations, param: :name, only: :show do

db/migrate/20180425091037_create_user_app_data.rb

@@ -0,0 +1,13 @@
+class CreateUserAppData < ActiveRecord::Migration
+  def change
+    create_table :user_app_data do |t|
+      t.string :field_name
+      t.text :value
+      t.string :namespace
+      t.references :user, index: true, foreign_key: true
+      t.timestamps
+    end
+
+    add_index :user_app_data, [:user_id, :field_name, :namespace], unique: true
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20180322124723) do
+ActiveRecord::Schema.define(version: 20180425091037) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -377,6 +377,18 @@
 
   add_index "unlocks", ["user_id", "course_id", "exercise_name"], name: "index_unlocks_on_user_id_and_course_id_and_exercise_name", unique: true, using: :btree
 
+  create_table "user_app_data", force: :cascade do |t|
+    t.string   "field_name"
+    t.text     "value"
+    t.string   "namespace"
+    t.integer  "user_id"
+    t.datetime "created_at"
+    t.datetime "updated_at"
+  end
+
+  add_index "user_app_data", ["user_id", "field_name", "namespace"], name: "index_user_app_data_on_user_id_and_field_name_and_namespace", unique: true, using: :btree
+  add_index "user_app_data", ["user_id"], name: "index_user_app_data_on_user_id", using: :btree
+
   create_table "user_field_values", force: :cascade do |t|
     t.integer  "user_id",    null: false
     t.string   "field_name", null: false
@@ -426,5 +438,6 @@
   add_foreign_key "submissions", "users", on_delete: :cascade
   add_foreign_key "test_case_runs", "submissions", on_delete: :cascade
   add_foreign_key "test_scanner_cache_entries", "courses", on_delete: :cascade
+  add_foreign_key "user_app_data", "users"
   add_foreign_key "user_field_values", "users", on_delete: :cascade
 end