Assistants can add asssistants

Author: nygrenh

app/controllers/setup/course_assistants_controller.rb

@@ -2,7 +2,7 @@ class Setup::CourseAssistantsController < Setup::SetupController
   before_action :set_course
 
   def index
-    authorize! :teach, @organization
+    authorize! :modify_assistants, @course
     @setup_in_progress = setup_in_progress?
 
     @assistants = @course.assistants
@@ -17,7 +17,7 @@ def index
   end
 
   def create
-    authorize! :teach, @organization
+    authorize! :modify_assistants, @course
 
     if params[:commit] == 'Add new assistant'
       new_assistant = User.find_by(login: assistant_params[:username])
@@ -43,7 +43,7 @@ def create
   end
 
   def destroy
-    authorize! :remove_assistant, @course
+    authorize! :modify_assistants, @course
     @assistantship = Assistantship.find(params[:id])
     destroyed_username = @assistantship.user.login
     @assistantship.destroy!

app/models/ability.rb

@@ -239,8 +239,8 @@ def initialize(user)
         can? :teach, o
       end
 
-      can :remove_assistant, Course do |c|
-        can? :teach, c.organization
+      can :modify_assistants, Course do |c|
+        can? :teach, c
       end
 
       can :edit, Organization do |o|

app/views/courses/show.html.erb

@@ -143,7 +143,7 @@
             <% if can? :manage_exercises, @course %>
               <%= link_to 'Manage exercises', manage_exercises_organization_course_path, class: "btn btn-default btn-sm" %>
             <% end %>
-            <% if can? :teach, @organization %>
+            <% if can? :modify_assistants, @course %>
               <%= link_to 'Manage assistants', setup_organization_course_course_assistants_path(@organization, @course), class: "btn btn-default btn-sm" %>
             <% end %>
           </li>