Skip to content

Commit 58bbef5

Browse files
committed
Improve Kafka task logging
1 parent 73944b3 commit 58bbef5

File tree

3 files changed

+233
-204
lines changed

3 files changed

+233
-204
lines changed

app/background_tasks/kafka_batch_update_points_task.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ def run
3434
Rails.logger.error("Cannot process task #{task.id} because task.task_type is not defined")
3535
end
3636
rescue => e
37-
Rails.logger.error("Task failed: #{e}")
37+
Rails.logger.error("Task failed: #{e.class.name}: #{e.message}")
38+
Rails.logger.error("Task failed backtrace: #{e.backtrace.join("\n")}") if e.backtrace
3839
end
3940
task.destroy! if finished_successfully
4041
end

app/background_tasks/kafka_realtime_update_points_task.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ def run
3434
Rails.logger.error("Cannot process task #{task.id} because task.task_type is not defined")
3535
end
3636
rescue => e
37-
Rails.logger.error("Task failed: #{e}")
37+
Rails.logger.error("Task failed: #{e.class.name}: #{e.message}")
38+
Rails.logger.error("Task failed backtrace: #{e.backtrace.join("\n")}") if e.backtrace
3839
end
3940
task.destroy! if finished_successfully
4041
end

0 commit comments

Comments
 (0)