Skip to content

Commit c7a13f0

Browse files
author
Irene
committed
Small refactorings
1 parent 36dd765 commit c7a13f0

File tree

5 files changed

+23
-27
lines changed

5 files changed

+23
-27
lines changed

app/assets/stylesheets/_breadcrumb.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
$breadcrumb-grey: #e9ecef;
22

33
.breadcumb-nav {
4+
align-items: center;
45
background-color: $breadcrumb-grey;
56
border-radius: 0.25rem;
67
display: flex;
7-
align-items: center;
88
padding-right: 1rem;
99

1010
.breadcrumb {

app/assets/stylesheets/_footer.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
$footer_height: 5rem;
1+
$footer-height: 5rem;
22

33
.footer {
4-
height: $footer_height;
4+
height: $footer-height;
55
background-color: rgb(54, 116, 214);
66
}
77

app/assets/stylesheets/main.scss

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@ div.stack-trace {
147147
}
148148

149149
.scrollable {
150-
width: 95vw;
151-
height: 70vh;
152150
align-self: center;
151+
height: 70vh;
153152
overflow: auto;
153+
width: 95vw;
154154
}
155155

156156
div.feedback-question {
@@ -171,6 +171,19 @@ form.single-button {
171171
table {
172172
border-collapse: collapse;
173173
width: 100%;
174+
175+
&.points {
176+
min-width: 100%;
177+
text-align: center;
178+
tbody tr:nth-child(odd) {
179+
background-color: lighten($breadcrumb-grey, 4%);
180+
}
181+
}
182+
183+
&.points tr.admin * {
184+
color: #808080;
185+
}
186+
174187
}
175188

176189
table > * > tr > td {
@@ -196,24 +209,6 @@ tr.table-totals > td {
196209
font-weight: bold;
197210
}
198211

199-
/* Points tables */
200-
201-
table.points {
202-
min-width: 100%;
203-
}
204-
205-
table.points tr.admin * {
206-
color: gray;
207-
}
208-
209-
table.points > * > tr > td {
210-
text-align: center;
211-
}
212-
213-
table.points > tbody tr:nth-child(odd) {
214-
background-color: lighten($breadcrumb-grey, 4%);
215-
}
216-
217212
/* Code reviews */
218213

219214
.code-review {
@@ -481,11 +476,12 @@ td.hljs-ln-code {
481476
}
482477

483478
.points-container {
479+
align-content: stretch;
484480
display: flex;
485481
flex-direction: column;
486-
align-content: stretch;
487482
}
488483

489-
#filter-form input[type="checkbox"], select {
484+
.filter-form input[type="checkbox"],
485+
select {
490486
margin: 0.2rem;
491487
}

app/assets/stylesheets/points.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import "_breadcrumb";
1+
@import "breadcrumb";
22

33
.course-point-header {
44
display: flex;

app/views/participants/index.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<h1>List of participants</h1>
22

3-
<%= form_tag(participants_path, :method => :get, :id => "filter-form") do %>
3+
<%= form_tag(participants_path, :method => :get, :class => "filter-form") do %>
44
<div style="float: left">
55
<%= render :partial => 'participants/filter_controls' %>
66
</div>

0 commit comments

Comments
 (0)