Code style for models

Author: nygrenh

app/models/ability.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # CanCan ability definitions.
 #
 # See: https://github.com/CanCanCommunity/cancancan/wiki/Defining-Abilities

app/models/action_token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'securerandom'
 
 # Each user may have 0..1 password reset keys.
@@ -12,13 +14,13 @@ class ActionToken < ActiveRecord::Base
 
   before_create :randomize_token
 
-  enum action: [:confirm_email, :reset_password, :enroll_course]
+  enum action: %i[confirm_email reset_password enroll_course]
 
   def self.generate_password_reset_key_for(user)
     old_key = user.password_reset_key
-    old_key.destroy if old_key
+    old_key&.destroy
 
-    key = self.create!(user: user, action: :reset_password, expires_at: Time.now + 72.hours)
+    key = create!(user: user, action: :reset_password, expires_at: Time.now + 72.hours)
     user.action_tokens << key
     key
   end

app/models/api_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApiVersion
   API_VERSION = 7 # To be incremented on BC-breaking changes
 end

app/models/assistantship.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Assistantship < ActiveRecord::Base
   belongs_to :user
   belongs_to :course

app/models/available_point.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Caches points that can be awarded from an exercise.
 # Awarded points don't have a hard reference to these because
 # these are recreated every time a course is refreshed.
@@ -7,8 +9,8 @@ class AvailablePoint < ActiveRecord::Base
   include Swagger::Blocks
 
   swagger_schema :AvailablePoint do
-    key :required, [
-      :id, :exercise_id, :name, :require_review
+    key :required, %i[
+      id exercise_id name require_review
     ]
 
     property :id, type: :integer, example: 1

app/models/awarded_point.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Stores when a point (course_id, name) has been awared to a particular user.
 #
 # There is a reference to the submission that first awarded the point, but this
@@ -8,7 +10,7 @@ class AwardedPoint < ActiveRecord::Base
   include Swagger::Blocks
 
   swagger_schema :AwardedPoint do
-    key :required, [:id, :course_id, :user_id, :submission_id, :name, :created_at]
+    key :required, %i[id course_id user_id submission_id name created_at]
 
     property :id, type: :integer, example: 1
     property :course_id, type: :integer, example: 1
@@ -19,18 +21,18 @@ class AwardedPoint < ActiveRecord::Base
   end
 
   def point_as_json
-    as_json only: [
-      :id,
-      :course_id,
-      :user_id,
-      :submission_id,
-      :name,
-      :created_at
+    as_json only: %i[
+      id
+      course_id
+      user_id
+      submission_id
+      name
+      created_at
     ]
   end
 
   swagger_schema :AwardedPointWithExerciseId do
-    key :required, [:awarded_point, :exercise_id]
+    key :required, %i[awarded_point exercise_id]
 
     property :awarded_point do
       key :"$ref", :AwardedPoint

app/models/certificate.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Certificate < ActiveRecord::Base
   belongs_to :user
   belongs_to :course
@@ -35,8 +37,7 @@ def generate
                           margin_bottom: '0.20in',
                           margin_left: '0.20in',
                           image_quality: 100,
-                          image_dpi: 300,
-                         ).to_pdf
+                          image_dpi: 300).to_pdf
   end
 
   def path

app/models/comet_server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rest_client'
 
 # Represents the configured tmc-comet server.
@@ -32,7 +34,7 @@ def client_url
   def try_publish(channel, msg)
     publish(channel, msg)
     true
-  rescue
+  rescue StandardError
     ::Rails.logger.error "Failed to publish to #{publish_url}: #{$!}"
     false
   end

app/models/comment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Comment < ActiveRecord::Base
   belongs_to :user
   belongs_to :submission