simple model test, readme update, controller test update

Author: BryanDonovan

README.md

@@ -1,4 +1,12 @@
 nodejs-tdd-boilerplate
 ======================
 
-NodeJS TDD Boilerplate
+#NodeJS TDD Boilerplate
+
+##Features
+
+*  mocha test framework.
+*  sinon stubbing framework.
+*  istanbul test coverage framework.
+*  jshint code linting.
+*  restify REST framework.

lib/models/user.js

@@ -1,8 +1,9 @@
-function User() {
+function User(args) {
+    this.id = args.id;
 }
 
 User.create = function (args, cb) {
-    cb(null, {id: 123});
+    cb(null, new User(args));
 };
 
 module.exports = User;

lib/server/app_server.js

@@ -5,6 +5,15 @@ var Logger = require('bunyan');
 var ENV = process.env.NODE_ENV;
 
 var log_path = path.resolve(__dirname, '..', '..', 'log', ENV + '.log');
+var logger = new Logger({
+    name: 'app',
+    streams: [
+        {
+            path: '/tmp/app.log',
+            level: 'debug'
+        }
+    ]
+});
 
 function AppServer(config, options) {
     var self = this;
@@ -16,20 +25,13 @@ function AppServer(config, options) {
 
     self.server = restify.createServer({
         name: config.app_name || 'MyApi',
-        log: new Logger({
-            name: 'app',
-            path: log_path
-        })
+        log: logger
     });
 
-    /*
     self.server.on('after', restify.auditLogger({
-        log: new Logger({
-            name: 'audit',
-            path: log_path
-        })
+        name: 'audit',
+        log: logger
     }));
-    */
 
     process.on('SIGHUP', function () { process.exit(); });
 }

test/apps/users/controller.unit.js

@@ -1,3 +1,4 @@
+var restify = require('restify');
 var assert = require('assert');
 var sinon = require('sinon');
 var support = require('../../support');
@@ -19,18 +20,40 @@ describe("users/controller.js", function () {
     });
 
     describe("POST /users", function () {
+        var params;
+
+        beforeEach(function () {
+            params = {username: support.random.string(), password: support.random.string()};
+        });
+
         it("passes params to User model", function (done) {
             sinon.stub(User, 'create', function (args, cb) {
                 cb(null, {});
             });
 
-            var params = {username: support.random.string(), password: support.random.string()};
-
             http_client.post('/users', params, function (err, result) {
                 assert.ifError(err);
                 assert.ok(User.create.calledWith(params));
+                User.create.restore();
                 done();
             });
         });
+
+        context("when model returns an error", function () {
+            it("responds with the error", function (done) {
+                var fake_err = new restify.InvalidArgumentError('foo');
+                sinon.stub(User, 'create', function (args, cb) {
+                    cb(fake_err, {});
+                });
+
+                http_client.post('/users', params, function (err, result) {
+                    assert.ok(User.create.calledWith(params));
+                    assert.equal(result.code, 'InvalidArgument');
+                    assert.equal(result.message, 'foo');
+                    User.create.restore();
+                    done();
+                });
+            });
+        });
     });
 });

test/models/user.unit.js

@@ -0,0 +1,15 @@
+var assert = require('assert');
+var support = require('../support');
+var User = main.models.User;
+
+describe("User model", function () {
+    describe("create()", function () {
+        it("returns dummy result for now", function (done) {
+            User.create({id: 'foo'}, function (err, result) {
+                assert.ifError(err);
+                assert.ok(result);
+                done();
+            });
+        });
+    });
+});