chore: correction setting request and response body

Wim Spaargaren · Wim Spaargaren · commit 37249c9093cc · 2020-10-12T13:59:57.000+02:00
diff --git a/proxywasm/hostcall.go b/proxywasm/hostcall.go
@@ -129,11 +129,10 @@ func GetHttpRequestBody(start, maxSize int) ([]byte, error) {
 }
 
 func SetHttpRequestBody(body []byte) error {
-	if len(body) == 0 {
-		st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpRequestBody, 0, len(body), nil, len(body))
-		return types.StatusToError(st)
+	var bufferData *byte
+	if len(body) != 0 {
+		bufferData = &body[0]
 	}
-	bufferData := &body[0]
 	st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpRequestBody, 0, len(body), bufferData, len(body))
 	return types.StatusToError(st)
 }
@@ -200,11 +199,10 @@ func GetHttpResponseBody(start, maxSize int) ([]byte, error) {
 }
 
 func SetHttpResponseBody(body []byte) error {
-	if len(body) == 0 {
-		st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpRequestBody, 0, len(body), nil, len(body))
-		return types.StatusToError(st)
+	var bufferData *byte
+	if len(body) != 0 {
+		bufferData = &body[0]
 	}
-	bufferData := &body[0]
 	st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpResponseBody, 0, len(body), bufferData, len(body))
 	return types.StatusToError(st)
 }

Original file line number	Diff line number	Diff line change
`@@ -129,11 +129,10 @@ func GetHttpRequestBody(start, maxSize int) ([]byte, error) {`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`func SetHttpRequestBody(body []byte) error {`
`132`		`- if len(body) == 0 {`
`133`		`- st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpRequestBody, 0, len(body), nil, len(body))`
`134`		`- return types.StatusToError(st)`
	`132`	`+ var bufferData *byte`
	`133`	`+ if len(body) != 0 {`
	`134`	`+ bufferData = &body[0]`
`135`	`135`	`}`
`136`		`- bufferData := &body[0]`
`137`	`136`	`st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpRequestBody, 0, len(body), bufferData, len(body))`
`138`	`137`	`return types.StatusToError(st)`
`139`	`138`	`}`
`@@ -200,11 +199,10 @@ func GetHttpResponseBody(start, maxSize int) ([]byte, error) {`
`200`	`199`	`}`
`201`	`200`
`202`	`201`	`func SetHttpResponseBody(body []byte) error {`
`203`		`- if len(body) == 0 {`
`204`		`- st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpRequestBody, 0, len(body), nil, len(body))`
`205`		`- return types.StatusToError(st)`
	`202`	`+ var bufferData *byte`
	`203`	`+ if len(body) != 0 {`
	`204`	`+ bufferData = &body[0]`
`206`	`205`	`}`
`207`		`- bufferData := &body[0]`
`208`	`206`	`st := rawhostcall.ProxySetBufferBytes(types.BufferTypeHttpResponseBody, 0, len(body), bufferData, len(body))`
`209`	`207`	`return types.StatusToError(st)`
`210`	`208`	`}`