chore: add e2e test for setting an http request body

Author: Wim Spaargaren

Makefile

@@ -19,6 +19,9 @@ test:
 test.e2e:
 	docker run -it -w /tmp/proxy-wasm-go -v $(shell pwd):/tmp/proxy-wasm-go getenvoy/proxy-wasm-go-sdk-ci:istio-${ISTIO_VERSION} go test -v ./e2e
 
+test.e2e.single:
+	docker run -it -w /tmp/proxy-wasm-go -v $(shell pwd):/tmp/proxy-wasm-go getenvoy/proxy-wasm-go-sdk-ci:istio-${ISTIO_VERSION} go test -v ./e2e -run ${name}
+
 run:
 	docker run --entrypoint='/usr/local/bin/envoy' \
 		-p 18000:18000 -p 8099:8099 \

e2e/e2e_test.go

@@ -117,6 +117,28 @@ func TestE2E_http_headers(t *testing.T) {
 	assert.True(t, strings.Contains(out, "server: envoy"))
 }
 
+func TestE2E_http_body(t *testing.T) {
+	cmd, stdErr := startExample(t, "http_body")
+	defer func() {
+		require.NoError(t, cmd.Process.Kill())
+	}()
+
+	req, err := http.NewRequest("GET", envoyEndpoint, bytes.NewBuffer([]byte(`{ "example": "body" }`)))
+	require.NoError(t, err)
+
+	r, err := http.DefaultClient.Do(req)
+	require.NoError(t, err)
+	defer r.Body.Close()
+
+	out := stdErr.String()
+	fmt.Println(out)
+	assert.True(t, strings.Contains(out, "body size: 21"))
+	assert.True(t, strings.Contains(out, `initial request body: { "example": "body" }`))
+	assert.True(t, strings.Contains(out, "on http request body finished"))
+	assert.False(t, strings.Contains(out, "failed to set request body"))
+	assert.False(t, strings.Contains(out, "failed to get request body"))
+}
+
 func TestE2E_network(t *testing.T) {
 	cmd, stdErr := startExample(t, "network")
 	defer func() {

examples/http_body/README.md

@@ -1,4 +1,4 @@
-## http_headers
+## http_body
 
 this example replaces the request body
 

examples/http_body/envoy.yaml

@@ -33,7 +33,7 @@ static_resources:
                           runtime: "envoy.wasm.runtime.v8"
                           code:
                             local:
-                              filename: "./examples/http_headers/main.go.wasm"
+                              filename: "./examples/http_body/main.go.wasm"
                           allow_precompiled: true
                   - name: envoy.router
                     config: {}

examples/http_body/main.go

@@ -36,22 +36,24 @@ func newContext(rootContextID, contextID uint32) proxywasm.HttpContext {
 // override
 func (ctx *httpBody) OnHttpRequestBody(bodySize int, endOfStream bool) types.Action {
 	proxywasm.LogInfof("body size: %d", bodySize)
-
-	b, err := proxywasm.GetHttpRequestBody(0, bodySize)
-	if err != nil {
-		proxywasm.LogErrorf("failed to get request body: %v", err)
-		return types.ActionContinue
+	if bodySize != 0 {
+		initialBody, err := proxywasm.GetHttpRequestBody(0, bodySize)
+		if err != nil {
+			proxywasm.LogErrorf("failed to get request body: %v", err)
+			return types.ActionContinue
+		}
+		proxywasm.LogInfof("initial request body: %s", string(initialBody))
+
+		b := []byte(`{ "another": "body" }`)
+
+		err = proxywasm.SetHttpRequestBody(b)
+		if err != nil {
+			proxywasm.LogErrorf("failed to set request body: %v", err)
+			return types.ActionContinue
+		}
+
+		proxywasm.LogInfof("on http request body finished")
 	}
 
-	proxywasm.LogInfof("initial request body: %s", string(b))
-
-	err = proxywasm.SetHttpRequestBody([]byte(`{"test":"data"}`))
-	if err != nil {
-		proxywasm.LogErrorf("failed to get request body: %v", err)
-		return types.ActionContinue
-	}
-
-	proxywasm.LogInfof("on http request body finished")
-
 	return types.ActionContinue
 }

examples/http_body/main_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/tetratelabs/proxy-wasm-go-sdk/proxywasm/types"
 )
 
-func TestHttpHeaders_OnHttpRequestHeaders(t *testing.T) {
+func TestHttpBody_OnHttpRequestBody(t *testing.T) {
 	opt := proxytest.NewEmulatorOption().
 		WithNewHttpContext(newContext)
 	host := proxytest.NewHostEmulator(opt)
@@ -19,7 +19,7 @@ func TestHttpHeaders_OnHttpRequestHeaders(t *testing.T) {
 	host.HttpFilterPutRequestBody(id, []byte(`{ "initial": "request body" }`))
 
 	res := host.HttpFilterGetRequestBody(id)
-	assert.Equal(t, `{"test":"data"}`, string(res))
+	assert.Equal(t, `{ "another": "body" }`, string(res))
 
 	logs := host.GetLogs(types.LogLevelInfo)
 	require.Greater(t, len(logs), 1)