refactor: 重命名一个不准确的类名

Author: textGamex

….Core/Models/Character/CharacterTrait.cs …er.Core/Models/Character/GeneralTrait.csVModer.Core/Models/Character/CharacterTrait.cs renamed to VModer.Core/Models/Character/GeneralTrait.cs VModer.Core/Models/Character/CharacterTrait.cs renamed to VModer.Core/Models/Character/GeneralTrait.cs

@@ -3,9 +3,9 @@
 namespace VModer.Core.Models.Character;
 
 /// <summary>
-/// 人物特质
+/// 除去领导人之外的特质
 /// </summary>
-public sealed class CharacterTrait
+public sealed class GeneralTrait
 {
     public string Name { get; }
     public TraitType Type { get; }
@@ -19,7 +19,7 @@ public sealed class CharacterTrait
 
     public ModifierCollection[] ModifiersCollection { get; }
 
-    public CharacterTrait(string name, TraitType type, IEnumerable<ModifierCollection> modifiers)
+    public GeneralTrait(string name, TraitType type, IEnumerable<ModifierCollection> modifiers)
     {
         Name = name;
         Type = type;

VModer.Core/Services/GameResource/GeneralTraitsService.cs

@@ -16,13 +16,13 @@
 namespace VModer.Core.Services.GameResource;
 
 public sealed class GeneralTraitsService
-    : CommonResourcesService<GeneralTraitsService, FrozenDictionary<string, CharacterTrait>>
+    : CommonResourcesService<GeneralTraitsService, FrozenDictionary<string, GeneralTrait>>
 {
     private readonly LocalizationFormatService _localizationFormatService;
     private readonly ModifierDisplayService _modifierDisplayService;
     private readonly GameResourcesPathService _gameResourcesPathService;
     private readonly ModifierService _modifierService;
-    private ICollection<FrozenDictionary<string, CharacterTrait>> Traits => Resources.Values;
+    private ICollection<FrozenDictionary<string, GeneralTrait>> Traits => Resources.Values;
 
     /// <summary>
     /// 特质修饰符节点名称
@@ -105,15 +105,15 @@ public List<TraitDto> GetAllTraitDto()
         return traits;
     }
 
-    public IEnumerable<string> GetModifiersDescription(CharacterTrait trait)
+    public IEnumerable<string> GetModifiersDescription(GeneralTrait trait)
     {
         var descriptions = new List<string>(8);
 
         foreach (var modifierCollection in trait.ModifiersCollection)
         {
             if (
                 modifierCollection.Key.Equals(
-                    CharacterTrait.TraitXpFactor,
+                    GeneralTrait.TraitXpFactor,
                     StringComparison.OrdinalIgnoreCase
                 )
             )
@@ -135,7 +135,7 @@ public IEnumerable<string> GetModifiersDescription(CharacterTrait trait)
         return descriptions;
     }
 
-    public bool TryGetTrait(string name, [NotNullWhen(true)] out CharacterTrait? trait)
+    public bool TryGetTrait(string name, [NotNullWhen(true)] out GeneralTrait? trait)
     {
         foreach (var traitMap in Traits)
         {
@@ -149,12 +149,12 @@ public bool TryGetTrait(string name, [NotNullWhen(true)] out CharacterTrait? tra
         return false;
     }
 
-    private string GetLocalizationName(CharacterTrait characterTrait)
+    private string GetLocalizationName(GeneralTrait generalTrait)
     {
-        return _localizationFormatService.GetFormatText(characterTrait.Name);
+        return _localizationFormatService.GetFormatText(generalTrait.Name);
     }
 
-    protected override FrozenDictionary<string, CharacterTrait>? ParseFileToContent(Node rootNode)
+    protected override FrozenDictionary<string, GeneralTrait>? ParseFileToContent(Node rootNode)
     {
         // Character Traits 和 技能等级修正 在同一个文件夹中, 这里我们只处理 Character Traits 文件
         var traitsNodes = Array.FindAll(
@@ -170,7 +170,7 @@ private string GetLocalizationName(CharacterTrait characterTrait)
         }
 
         // 在 1.14 版本中, 人物特质文件中大约有 145 个特质
-        var dictionary = new Dictionary<string, CharacterTrait>(163, StringComparer.OrdinalIgnoreCase);
+        var dictionary = new Dictionary<string, GeneralTrait>(163, StringComparer.OrdinalIgnoreCase);
         foreach (var traitsChild in traitsNodes)
         {
             traitsChild.TryGetNode(out var traitsNode);
@@ -189,9 +189,9 @@ private string GetLocalizationName(CharacterTrait characterTrait)
     /// </summary>
     /// <param name="traitsNode">文件中的 leader_traits 节点</param>
     /// <returns></returns>
-    private ReadOnlySpan<CharacterTrait> ParseTraitsNode(Node traitsNode)
+    private ReadOnlySpan<GeneralTrait> ParseTraitsNode(Node traitsNode)
     {
-        var traits = new List<CharacterTrait>(traitsNode.AllArray.Length);
+        var traits = new List<GeneralTrait>(traitsNode.AllArray.Length);
 
         foreach (var child in traitsNode.AllArray)
         {
@@ -220,7 +220,7 @@ private ReadOnlySpan<CharacterTrait> ParseTraitsNode(Node traitsNode)
                         Array.Exists(
                             ModifierNodeKeys,
                             keyword => StringComparer.OrdinalIgnoreCase.Equals(keyword, key)
-                        ) || StringComparer.OrdinalIgnoreCase.Equals(key, CharacterTrait.TraitXpFactor)
+                        ) || StringComparer.OrdinalIgnoreCase.Equals(key, GeneralTrait.TraitXpFactor)
                     )
                 )
                 {
@@ -241,7 +241,7 @@ private ReadOnlySpan<CharacterTrait> ParseTraitsNode(Node traitsNode)
 
             if (skillModifiers.Count != 0)
             {
-                modifiers.Add(new ModifierCollection(CharacterTrait.TraitSkillModifiersKey, skillModifiers));
+                modifiers.Add(new ModifierCollection(GeneralTrait.TraitSkillModifiersKey, skillModifiers));
             }
 
             if (customModifiersTooltip.Count != 0)
@@ -250,7 +250,7 @@ private ReadOnlySpan<CharacterTrait> ParseTraitsNode(Node traitsNode)
                     new ModifierCollection(LeafModifier.CustomEffectTooltipKey, customModifiersTooltip)
                 );
             }
-            traits.Add(new CharacterTrait(traitName, traitType, modifiers));
+            traits.Add(new GeneralTrait(traitName, traitType, modifiers));
         }
 
         return CollectionsMarshal.AsSpan(traits);