5.9 Todo List

[KVonGit]

• ShowMenuResponse
  • Needs to check if the result is an object
    • if yes, result = GetDisplayAlias(result)

This code is already written. Waiting on a file in an open PR.

OUTDATED
SCROLL DOWN FOR NEW CODE

---

• Word Wrap option should apply to script textboxes (and expression textboxes)
  • Need to figure this out, it has defeated me every time I tried

---

• Spell Check in the desktop editor(?)
  • I actually added this to 5.8, but couldn't test in other languages, therefore removed it before release

32015d8

[KVonGit]

#1274

#1279

---

No clue how to fix either of these.

[Pertex]

GetDisplayAlias(GetObject(option)))
does this work if option is not an object but just a string?

[KVonGit]

It should only do that when game.disambiguating is true, which (I think) should mean it's definitely an object name.

[KVonGit]

does this work if option is not an object but just a string?

Valid point, though. Should double check.

This better? :)

MORE OLD CODE REMOVED

KEEP SCROLLING...

[KVonGit]

Testing game:

<!--Saved by Quest 5.9.9150.18408-->
<asl version="580">
  <include ref="English.aslx" />
  <include ref="Core.aslx" />
  <game name="Testing GetDisplayAlias in ShowMenuResponse">
    <gameid>88e04581-e1a7-48ff-a0f4-643134359a8a</gameid>
    <version>1.0</version>
    <firstpublished>2025</firstpublished>
    <donotclearmenus />
    <showmenuresponses />
  </game>
  <object name="room">
    <inherit name="editor_room" />
    <description>
      {command:x ball} | {command:test} | {command:test2}
    </description>
    <object name="player">
      <inherit name="editor_object" />
      <inherit name="editor_player" />
    </object>
    <object name="ball1">
      <inherit name="editor_object" />
      <alias>big ball</alias>
    </object>
    <object name="ball2">
      <inherit name="editor_object" />
      <alias>little ball</alias>
    </object>
  </object>
  <command name="test" pattern="test">
    <script>
      s = "Choose!"
      options = NewStringDictionary()
      dictionary add (options, "uno", "one")
      dictionary add (options, "dos", "two")
      ShowMenu (s, options, false){
        msg ("You chose: " + result)
      }
    </script>
  </command>
  <command name="test2" pattern="test2">
    <script>
      s = "Choose!"
      options = Split ("three;four")
      ShowMenu (s, options, false){
        msg ("You chose: " + result)
      }
    </script>
  </command>
  <function name="ShowMenuResponse" parameters="option"><![CDATA[
    if (game.menucallback = null) {
      error ("Unexpected menu response")
    }
    else {
      parameters = NewStringDictionary()
      dictionary add (parameters, "result", UnescapeQuotes(option))
      script = game.menucallback
      if (GetBoolean (game, "donotclearmenus")) {
        DisableMenu
      }
      else {
        ClearMenu
      }
      if (not GetBoolean(game, "disambiguating")) {
        game.runturnscripts = true
      }
      else {
        if (GetBoolean (game, "showmenuresponses")) {
          obj = GetObject (option)
          if (obj <> null){
            option = GetDisplayAlias(obj)
          }
          msg (Template("ShowMenuResponsePrompt") + option)
        }
      }
      game.disambiguating = false
      invoke (script, parameters)
      FinishTurn
    }
  ]]></function>
  <function name="DisableMenu">
    DisableOutputSection (game.menuoutputsection)
    game.menuoutputsection = null
    game.menuoptions = null
    game.menucallback = null
  </function>
  <function name="DisableOutputSection" parameters="section">
    // The next line would be in playercore.js
    JS.eval ("function disableCmdLink(el){ $('.' + el + ' .cmdlink').addClass('disabled').attr('onclick',null); }")
    JS.disableCmdLink (section)
  </function>
</asl>

[KVonGit]

Okay, Pertex, I think I've got it all together...

We'd have to change ShowMenuResponse thusly:

  <function name="ShowMenuResponse" parameters="option"><![CDATA[
    if (game.menucallback = null) {
      error ("Unexpected menu response")
    }
    else {
      parameters = NewStringDictionary()
      dictionary add (parameters, "result", UnescapeQuotes(option))
      script = game.menucallback
      if (GetBoolean (game, "donotclearmenus")) {
        DisableMenu
      }
      else {
        ClearMenu
      }
      if (not GetBoolean(game, "disambiguating")) {
        game.runturnscripts = true
      }
      else {
        if (GetBoolean (game, "showmenuresponses")) {
          obj = GetObject (option)
          if (obj <> null){
            option = GetDisplayAlias(obj)
          }
          msg (Template("ShowMenuResponsePrompt") + option)
        }
      }
      game.disambiguating = false
      invoke (script, parameters)
      FinishTurn
    }
  ]]></function>

---

Then add these two functions:

  <function name="DisableMenu">
    DisableMenuOutputSection (game.menuoutputsection)
    game.menuoutputsection = null
    game.menuoptions = null
    game.menucallback = null
  </function>

  <function name="DisableMenuOutputSection" parameters="section">
    JS.disableMenuOutputSection (section)
  </function>

---

Then add this to playercore.js (if there isn't already a function like this, but I couldn't find one):

function disableMenuOutputSection (el){
    $('.' + el + ' .cmdlink').addClass('disabled').attr('onclick',null);
}

---

Also, I don't know if we should add these to the game object by default (if yes, possibly along with editor controls, but probably not?):

    <donotclearmenus type="boolean">false</donotclearmenus>
    <showmenuresponses type="boolean">false</showmenuresponses>

[Pertex]

will it be possible to change these parameter (donotclearmenus ,showmenuresponses ) in the editor?

[KVonGit]

We can add checkboxes. Which tab should they be on?

[Pertex]

that is the question. the game / feature-tab?

[KVonGit]

Sorry, I was away from my desk for a while there.

You think it might fit better with this bit?

[KVonGit]

[Pertex]

yes, above 'Verb Menu' with a new Headline 'Menus'

[KVonGit]

Oh, whoops! Just saw this after posting that screenshot.

I almost put "Menus", but that seemed like it would be confusing right above "Verb Menus".

[KVonGit]

[alexwarren]

Is everything done here now? Or are there still issues to be added?

[KVonGit]

Do we want to add this stuff to ShowMenu?

(I fell down a Legacy Game rabbit hole, and I left Pertex hanging on this one. I'll focus on things concerning ASL version >= 580 until 5.9 drops!)

[KVonGit]

Nice. I think that means we might be just about ready for release then?

Definitely looks about ready for some serious beta-testing to me.

I'm about to sync the master branch in my fork and build the project. (I'm not sure @Pertex doesn't know of something I'm not thinking of at the moment, but I'd be testing these recent changes today regardless.)

[alexwarren]

I haven't been following, what is the ShowMenu change - is there an issue/PR link?

[KVonGit]

We were considering adding an option to leave the menu text intact after making a choice.

#1387 (comment)

[alexwarren]

If that's not ready yet then maybe it's missed the bus for this release and it can go in the next one. (Unless there are other bugs that need fixing, and this one becomes ready and sneaks in with them)

[KVonGit]

The only other things on my list are adding spell check and "extending" word-wrap to also work in the script textboxes when the option is selected in the user settings.

Spell-check would need a new user setting, and it probably wouldn't work correctly in certain languages anyway.

...and I found no easy way to add code to make word-wrap in script textboxes tied to Quest's current word-wrap user settings.

Neither of these sound worthwhile to me at this juncture.

[alexwarren]

Makes sense, thanks!