upgrade to phpstan 2 (#15)

Author: mathroc

.devcontainer/devcontainer.json

@@ -7,6 +7,9 @@
 		// Update 'VARIANT' to pick an Alpine version: 3.12, 3.13, 3.14, 3.15
 		"args": { "VARIANT": "3.14" }
 	},
+	"runArgs": [
+		"--security-opt=label=disable" 
+	],
 	"workspaceMount": "source=${localWorkspaceFolder},target=/app,type=bind",
 	"workspaceFolder": "/app",
 	"remoteEnv": {

.docker/Dockerfile

@@ -15,6 +15,7 @@ COPY --from=composer:2.8 /usr/bin/composer /usr/bin/composer
 
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive && \
     bash /tmp/library-scripts/dev.sh "${USERNAME}"
+RUN docker-php-ext-install zip && docker-php-ext-enable zip
 
 RUN mkdir /app && chown ${USERNAME}: /app
 

.docker/dev.sh

@@ -65,6 +65,7 @@ if [ "${PACKAGES_ALREADY_INSTALLED}" != "true" ]; then
         libicu[0-9][0-9] \
         liblttng-ust[0-9] \
         libstdc++6 \
+        libzip-dev \
         zlib1g \
         locales \
         init-system-helpers"

composer.json

@@ -26,9 +26,9 @@
         "php": "^8.2",
         "squizlabs/php_codesniffer": "^4.0",
         "slevomat/coding-standard": "^8.0",
-        "phpstan/phpstan": "^1.12",
+        "phpstan/phpstan": "^2.0",
         "phpstan/extension-installer": "^1.1",
-        "phpstan/phpstan-strict-rules": "^1.1",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^11.3||^12.0",
         "texthtml/doctest": "^0.3.0"
     },

examples/Integer.php

@@ -3,7 +3,6 @@
 namespace TH\VOIdentity\Tests\Cloning;
 
 use TH\VOIdentity\Identity;
-use PHPUnit\Framework\TestCase;
 
 /**
  * ```php

examples/Money.php

@@ -3,7 +3,6 @@
 namespace TH\VOIdentity\Tests\Cloning;
 
 use TH\VOIdentity\Identity;
-use PHPUnit\Framework\TestCase;
 
 /**
  * ```php
@@ -33,11 +32,16 @@ protected function __construct(
     }
 
     public static function of(int|float $value, string $currency): self {
+        // @phpstan-ignore argument.type,argument.type
         return self::ofMinor((int) ($value * 100), $currency);
     }
 
+    /**
+     * @param int<1,max> $n
+     */
     public function dividedBy(int $n): self
     {
+        // @phpstan-ignore argument.type,argument.type
         return self::ofMinor($this->cents / $n, $this->currency);
     }
 }

examples/TsRange.php

@@ -3,7 +3,6 @@
 namespace TH\VOIdentity\Tests\Cloning;
 
 use TH\VOIdentity\Identity;
-use PHPUnit\Framework\TestCase;
 
 /**
  * ```php
@@ -31,7 +30,11 @@ protected function __construct(
     ) {
     }
 
+    /**
+     * @throws \DateMalformedStringException
+     */
     public function extendBy(string $relativeTime): self {
+        // @phpstan-ignore argument.type,argument.type
         return self::of($this->start, $this->end->modify($relativeTime));
     }
 }

examples/UserID.php

@@ -3,7 +3,6 @@
 namespace TH\VOIdentity\Tests\Cloning;
 
 use TH\VOIdentity\Identity;
-use PHPUnit\Framework\TestCase;
 
 /**
  * ```php

phpstan.neon.dist

@@ -1,8 +1,13 @@
 parameters:
-	level: 9
-	paths:
-		- src
-	exceptions:
-		check:
-			missingCheckedExceptionInThrows: true
-			tooWideThrowType: true
+    level: 9
+    paths:
+        - src
+        - examples
+    exceptions:
+        check:
+            missingCheckedExceptionInThrows: true
+            tooWideThrowType: true
+    ignoreErrors:
+        -
+            identifier: property.onlyWritten
+            path: examples/

src/Identity.php

@@ -14,13 +14,14 @@ private function __construct() {}
      * @param array<mixed> $args
      */
     final public static function of(mixed ...$args): self {
+        // @phpstan-ignore argument.type
         $constructor = static fn () => new self(...$args);
 
         return self::resolve($constructor, self::inputIdentity(...$args));
     }
 
     /**
-     * @param self|callable():self $ref
+     * @param callable():self $ref
      * @phpstan-param array-key|null $key
      */
     final protected static function resolve(callable $ref, int|string|null $key): self {
@@ -33,6 +34,7 @@ final protected static function resolve(callable $ref, int|string|null $key): se
         static $mem = [];
 
         if (\array_key_exists($key, $mem)) {
+            // @phpstan-ignore return.type
             return $mem[$key]->get();
         }
 
@@ -64,13 +66,17 @@ protected static function inputIdentity(mixed ...$args): int|string|null {
         return null;
     }
 
+    /**
+     * @throws \LogicException
+     */
     final public function __clone(): never
     {
         throw new \LogicException('Value Object ' . static::class . ' using ' . Identity::class . ' can\'t be cloned');
     }
 
     /**
      * @param array<mixed> $data
+     * @throws \LogicException
      */
     final public function __unserialize(array $data): never
     {
@@ -88,6 +94,7 @@ final public function __unserialize(array $data): never
      */
     public static function __set_state(array $data): self
     {
+        // @phpstan-ignore argument.type
         return self::of(...$data);
     }
 }