Skip to content

Commit 91316ee

Browse files
fix: sass deprecation warnings (#1292)
* upgraded sass to the latest version and solved some issues * update package-lock * reorder css attributes --------- Co-authored-by: André Nogueira <nogueira@textkernel.nl>
1 parent 0937ec5 commit 91316ee

File tree

12 files changed

+118
-67
lines changed

12 files changed

+118
-67
lines changed

package-lock.json

Lines changed: 77 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
"react-router-dom": "6.28.0",
144144
"react-transition-group": "4.4.5",
145145
"sass": "1.81.0",
146-
"sass-loader": "13.3.3",
146+
"sass-loader": "16.0.2",
147147
"sonner": "1.5.0",
148148
"standard-version": "9.5.0",
149149
"storybook": "7.6.20",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
@import '../Button/Button';
1+
@use '../Button/Button';

src/components/Buttons/IconButton/IconButton.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import '../Button/Button';
1+
@use '../Button/Button';
22

33
.IconButton {
44
&--size {

src/components/Callout/Callout.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
@use 'sass:list';
2-
@import '../../themes/oneui/constants/colors';
2+
@use '../../themes/oneui/constants/colors' as *;
33

44
$icon-size: 16px;
55

src/components/CandidateAvatar/CandidateAvatar.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import '../../themes/oneui/constants/colors';
1+
@use '../../themes/oneui/constants/colors';
22

33
.CandidateAvatar {
44
position: relative;
@@ -30,7 +30,7 @@
3030
}
3131

3232
&__percentage {
33-
background-color: rgba(0,0,0,.25);
33+
background-color: rgba(0, 0, 0, 0.25);
3434
border-radius: 50%;
3535
height: 100%;
3636
width: 100%;

src/components/DatePicker/DatePicker.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import '../../themes/oneui/placeholders/input';
1+
@use '../../themes/oneui/placeholders/input';
22

33
/* Input field */
44
:global .react-datepicker__input-container input {
@@ -111,7 +111,11 @@
111111
/* stylelint-disable */
112112
:global .react-datepicker__day--in-selecting-range,
113113
:global
114-
.react-datepicker__day--in-selecting-range:not(.react-datepicker__month-text--in-range, .react-datepicker__quarter-text--in-range, .react-datepicker__year-text--in-range),
114+
.react-datepicker__day--in-selecting-range:not(
115+
.react-datepicker__month-text--in-range,
116+
.react-datepicker__quarter-text--in-range,
117+
.react-datepicker__year-text--in-range
118+
),
115119
:global .react-datepicker__day--in-range {
116120
border-radius: 0;
117121
background-color: var(--color-brand-40);

src/components/Tag/Tag.scss

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,11 @@
77
border-radius: var(--space-50);
88
border: 1px solid var(--color-border-subtle);
99
cursor: default;
10-
background-color: var(--bg-color, white); // Fallback to --color-background if bgColor isn't provided
11-
10+
background-color: var(
11+
--bg-color,
12+
white
13+
); // Fallback to --color-background if bgColor isn't provided
14+
1215
&[disabled] {
1316
color: var(--color-text-disabled);
1417
}
@@ -20,7 +23,7 @@
2023
&--clickable:not([disabled]) {
2124
cursor: pointer;
2225

23-
&:hover:not([disabled]){
26+
&:hover:not([disabled]) {
2427
background-color: var(--color-background-neutral-subtlest-hover);
2528
}
2629

@@ -30,13 +33,13 @@
3033
}
3134
}
3235

33-
&__text{
34-
composes: OneUI-label-text from global;
36+
&__text {
3537
margin: 0;
3638
composes: OneUI-label-text from global;
3739
white-space: nowrap;
3840
overflow: hidden;
3941
text-overflow: ellipsis;
42+
4043
&[disabled] {
4144
color: var(--color-text-disabled);
4245
}
@@ -65,6 +68,5 @@
6568
fill: var(--color-text-disabled);
6669
cursor: default;
6770
}
68-
6971
}
7072
}

src/components/TextArea/TextArea.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@import '../../themes/oneui/placeholders/input';
1+
@use '../../themes/oneui/placeholders/input';
22

33
.TextArea {
44
@extend %input;

src/components/Toaster/Toaster.scss

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
@use "sass:map";
2-
@import '../../themes/oneui/oneui';
1+
@use 'sass:map';
2+
@use '../../themes/oneui/oneui';
33

44
$contexts: (info, success, cautious, critical);
55
$contextMap: (
66
'info': 'information',
77
'success': 'success',
88
'cautious': 'caution',
9-
'critical': 'critical'
9+
'critical': 'critical',
1010
);
1111

1212
.Toast {
@@ -31,20 +31,21 @@ $contextMap: (
3131
}
3232

3333
&__content {
34-
flex-grow: 1;
34+
flex-grow: 1;
3535
display: flex;
3636
flex-direction: column;
3737
gap: var(--space-150);
3838
}
3939

4040
&__message {
4141
gap: var(--space-100);
42-
display: flex;
42+
display: flex;
4343
flex-direction: column;
4444
margin: 0;
4545
font-family: var(--font-family-primary);
46-
h3, p {
47-
margin: 0;
46+
h3,
47+
p {
48+
margin: 0;
4849
}
4950
}
5051

@@ -64,7 +65,7 @@ $contextMap: (
6465
padding: 0;
6566
margin: 0;
6667
}
67-
68+
6869
&__closeButton {
6970
display: flex;
7071
align-items: flex-start;
@@ -76,16 +77,16 @@ $contextMap: (
7677
background-color: var(--transparent);
7778
border: none;
7879
outline: 0;
79-
80+
8081
&:focus {
8182
box-shadow: 0px 0px 0px 2px var(--color-background-neutral-subtlest-pressed);
82-
border-radius: var(--space-50);;
83+
border-radius: var(--space-50);
8384
}
8485
}
8586

8687
&__closeIcon {
8788
font-size: var(--space-300);
88-
color: var(--color-icon-subtle);
89+
color: var(--color-icon-subtle);
8990
fill: var(--color-icon-subtle);
9091
}
9192

0 commit comments

Comments
 (0)