Skip to content

Commit 60c25a7

Browse files
authored
fix(deps): update to kuromojin@3 (#7)
* fix(deps): update to kuromojin@3 * refactor: use import/default * chore(deps): update lock
1 parent 137a4c0 commit 60c25a7

File tree

9 files changed

+730
-581
lines changed

9 files changed

+730
-581
lines changed

.github/workflows/test.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: test
2+
on: [push, pull_request]
3+
jobs:
4+
test:
5+
name: "Test on Node.js ${{ matrix.node-version }}"
6+
runs-on: ubuntu-latest
7+
strategy:
8+
matrix:
9+
node-version: [12, 14]
10+
steps:
11+
- name: checkout
12+
uses: actions/checkout@v2
13+
- name: setup Node.js ${{ matrix.node-version }}
14+
uses: actions/setup-node@v2
15+
with:
16+
node-version: ${{ matrix.node-version }}
17+
- name: Install
18+
run: yarn install
19+
- name: Test
20+
run: yarn test

.travis.yml

Lines changed: 0 additions & 3 deletions
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# textlint-rule-no-insert-dropping-sa [![Build Status](https://travis-ci.org/textlint-ja/textlint-rule-no-insert-dropping-sa.svg?branch=master)](https://travis-ci.org/textlint-ja/textlint-rule-no-insert-dropping-sa)
1+
# textlint-rule-no-insert-dropping-sa [![Actions Status: test](https://github.com/textlint-ja/textlint-rule-no-insert-dropping-sa/workflows/test/badge.svg)](https://github.com/textlint-ja/textlint-rule-no-insert-dropping-sa/actions?query=workflow%3A"test")
22

33
サ抜き、サ入れ表現の誤用をチェックするtextlintルール
44

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@
3535
},
3636
"dependencies": {
3737
"array-find-index": "^1.0.2",
38-
"kuromojin": "^2.1.1",
39-
"morpheme-match-all": "^2.0.5"
38+
"kuromojin": "^3.0.0",
39+
"morpheme-match-all": "^2.0.5",
40+
"textlint-tester": "^5.3.4"
4041
}
4142
}

src/dict/sa-dropping-dict.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// 「サ抜き」方向の検出
44
// 本来あるべき「サ」が抜け落ちる「サ抜き」の場合、「サ」が確実に入る用例でおかしな「サ抜け」は、「無そう」「良そう」の2種類
55
// http://www.anlp.jp/proceedings/annual_meeting/2012/pdf_dir/B1-2.pdf
6-
module.exports = {
6+
export default {
77
message: "「さ」が抜けています。",
88
expected: "$1さ$2",
99
// https://azu.github.io/morpheme-match/?text=これは問題無そう

src/dict/sa-insert-dict.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// 動詞+助動詞「たい」+「そう」の形式は、本来どこをとっても「サ」が入る余地の無い
55
// 形式のはずだが、何故か「サ」が入る例が散見される
66
// http://www.anlp.jp/proceedings/annual_meeting/2012/pdf_dir/B1-2.pdf
7-
module.exports = [
7+
export default [
88
{
99
message: "不要な「さ」が挿入されています。",
1010
expected: "$2$3",

src/textlint-rule-no-insert-dropping-sa.js

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
// MIT © 2017 azu
22
"use strict";
3-
const arrayFindIndex = require("array-find-index");
4-
const kuromojin = require("kuromojin");
5-
const { createMatcher} = require("morpheme-match-all");
6-
const saInsertDict = require("./dict/sa-insert-dict");
7-
const saDroppingDict = require("./dict/sa-dropping-dict");
3+
import { tokenize } from "kuromojin";
4+
import arrayFindIndex from "array-find-index";
5+
import { createMatcher } from "morpheme-match-all";
6+
import saInsertDict from "./dict/sa-insert-dict";
7+
import saDroppingDict from "./dict/sa-dropping-dict";
8+
89
const matchAll = createMatcher(saInsertDict.concat([
910
saDroppingDict
1011
]));
@@ -44,9 +45,9 @@ const replaceWithCaptureTokens = (text, tokens, actualTokens) => {
4445
const reporter = (context) => {
4546
const { Syntax, RuleError, report, fixer, getSource } = context;
4647
return {
47-
[Syntax.Str](node){
48+
[Syntax.Str](node) {
4849
const text = getSource(node);
49-
return kuromojin.tokenize(text).then(tokens => {
50+
return tokenize(text).then(tokens => {
5051
const matchResults = matchAll(tokens);
5152
matchResults.forEach(matchResult => {
5253
const firstToken = matchResult.tokens[0];
@@ -75,7 +76,7 @@ const reporter = (context) => {
7576
}
7677
};
7778

78-
module.exports = {
79+
export default {
7980
linter: reporter,
8081
fixer: reporter
81-
};
82+
};

test/textlint-rule-no-insert-dropping-sa-test.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
// MIT © 2017 azu
22
"use strict";
3-
const TextLintTester = require("textlint-tester");
3+
import TextLintTester from "textlint-tester";
4+
import rule from "../src/textlint-rule-no-insert-dropping-sa";
45
const tester = new TextLintTester();
5-
// rule
6-
const rule = require("../src/textlint-rule-no-insert-dropping-sa");
76
tester.run("rule", rule, {
87
valid: [
98
// no problem
@@ -109,4 +108,4 @@ tester.run("rule", rule, {
109108
]
110109
},
111110
]
112-
});
111+
});

0 commit comments

Comments
 (0)