User Sitr0mis and ataxium's reported "Error"

[LegolandoBloom]

Here are the comments they wrote for reference:

"Having the EXACT same experience. If I had to guess, the addon is failing to check the "Char Favs" status on initial load or it is somehow being delayed its initial check; thus the default Blizz "favorite" marked pets are being seen as first from the addon and thus summoning those instead. I have to uncheck and recheck the "Char Favs (PW)" everytime to get it to function properly... but on load-up, it does not."

"since recent update, only summons pets at complete random. When using char favs or not"

I believe I know what they are referring to, and it's not exactly a logical error, but more of an "expectations vs reality" kind of situation. It's regarding the function: ns.saved_pet_summonability_check() (line 277)

function ns.saved_pet_summonability_check() --- After login
	local priorities, perchar = {}, nil

	if ns.dbc.charFavsEnabled then
		perchar = true
		priorities = {
			ns.dbc.recentPets[1],
			ns.dbc.recentPets[2],
                        ns.db.recentPets[1],
			ns.db.recentPets[2],
		}
	else
		priorities = {
			ns.db.recentPets[1],
			ns.db.recentPets[2],
                        ns.dbc.recentPets[1],
			ns.dbc.recentPets[2],
		}
	end
                 .
                 .
                 .
end

With the way it's implemented currently,
if an alt of yours doesn't have char favourites enabled and has a pet summoned:
if they then logout with that pet recently being unsummoned aka "saved" state -> then login to an alt that does have char favourites enabled
if that new alt didn't have a pet in their "saved" state previously, PetWalker will keep summoning(and saving) the non-char-favourite saved pet from the other character, and then believe that that pet was theirs even they manually summon one from the favourite pool.

For my current usage, I made this change to the priorities table for both options:

priorities = {
			ns.dbc.recentPets[1],
			ns.dbc.recentPets[2],
		}

priorities = {
			ns.db.recentPets[1],
			ns.db.recentPets[2],
		}

It's not a perfect solution, because there are sure to be people who like the previous functionality of resummoning previously saved non-char-fav pets from other characters.

I believe this is where their grievance lies, the 2 commentors.

[tflo]

The saved_pet_summonability_check function is a good catch.

The function has/had several problems:

• Not yet updated for the recently implemented history feature (= more than 1 previous pets)
• Thanks to my stupid usage of ipairs instead of pairs in the iteration, it will stop on the first nil in the array.

I fixed the 2nd one in the dev version, though it was probably not responsible for the reported behavior.

---

if an alt of yours doesn't have char favourites enabled and has a pet summoned: […]

I will try to reproduce what you described there. But probably not today (leveling at least one toon to 90 has priority ATM 😉)

---

The new feature that triggered my major 3.0 overhaul is the one from #25. It changes many things related to charFavs/globalFavs/AllPets.

The feature is explained in the changelog:

changelog dev6

#### 3.0.0-dev6 (2026-03-02)

• New feature: Configurable probability of favorite pets in All Pets mode. Idea by @tsemoana on GitHub.
  • You set the probability with the usual favorites toggle f command, but followed by a number between 0 and 1.
  • For example /pw f 0.5 gives you an equal probability (50%) that a random pet is picked from your favorites or from your non-favorites pool. With 0.9, nine out of ten pets (on average) will be from your favorites, and so on.
  • Hint: You don’t have to type the zero before the decimal point.
  • With /pw f 0, you’ll only ever get non-favorites.
  • /pw f 1 does not what you think, but will simply activate the old All Pets mode as you know it (all pets, favs and non-favs, in one single pool).
  • To summon only favorites, you just toggle from All Pets to Favs Only with /pw f (as it was before).
  • Your probability value is remembered, and used whenever you switch back to All Pets mode with /pw f.
  • When you set/change the probability value, PW will automatically go into All Pets mode, if you were in Favs Only mode.
• Auto-fix settings: When your active pool (for example, Favorites) doesn’t contain any summonable pet, PW will now actively try to fix the setting by switching to All Pets and generating a combined pool, as if you typed /pw f 1.
  • This should significantly reduce cases that trigger the Zero Pool warning/hints, which some apparently regarded as spam.
  • You should get the Zero Pool warning only if after reinitializing the pool with the fixed settings, there are still no pets in the pool. In this case, PW will also deactivate the auto-summon timer, as with /pw 0.
• Add messages, help, status for the new feature; reworked other chat prints and coloring.
• Change verbosity level for some messages.
• Nicer formatting of timer and remaining timer values in prints.
• Protect our /pw slash command from being hijacked by other addons (bad, bad guys).
• Major code cleanup and refactoring, WiP.
• Fix a malfunction in saved_pet_summonability_check (pairs).

Here my most recent version (including .git folder):

PetWalker-300-dev6.zip