Rename lower_bound_and_found to try_find (#286)

Since I added `try_set_key_type` in #285, I want to name all helper methods consistently.

Author: tfpf

src/pysorteddict/sorted_dict_type.cc

@@ -262,17 +262,17 @@ bool SortedDictType::is_nargs_good(char const* caller, Py_ssize_t nargs, int at_
 }
 
 /**
- * Find the lower bound of the given good key and report whether it was found.
- * (To determine whether a good key is present, check the second element of the
+ * Try to find the given good key.
+ *
+ * To determine whether a good key is present, check the second element of the
  * result; there is no meaningful performance impact of doing this instead of
- * calling `find` directly because it internally does the same thing done
- * here.)
+ * calling `find` directly because it internally does the same thing done here.
  *
  * @param key Good key.
  *
  * @return The lower bound of the given key and whether it was found.
  */
-std::pair<FwdIterType, bool> SortedDictType::lower_bound_and_found(PyObject* key)
+std::pair<FwdIterType, bool> SortedDictType::try_find(PyObject* key)
 {
     auto it = this->map->lower_bound(key);
     return { it, it != this->map->end() && !this->map->key_comp()(key, it->first) };
@@ -462,7 +462,7 @@ int SortedDictType::contains(PyObject* key, PyObject* value)
     {
         return -1;
     }
-    auto [it, found] = this->lower_bound_and_found(key);
+    auto [it, found] = this->try_find(key);
     if (!found)
     {
         return 0;
@@ -497,7 +497,7 @@ PyObject* SortedDictType::getitem(PyObject* key)
     {
         return nullptr;
     }
-    auto [it, found] = this->lower_bound_and_found(key);
+    auto [it, found] = this->try_find(key);
     if (!found)
     {
         PyErr_SetObject(PyExc_KeyError, key);
@@ -524,7 +524,7 @@ int SortedDictType::setitem(PyObject* key, PyObject* value)
 
     // Insertion will be faster if the approximate location is known. Hence,
     // look for the nearest match.
-    auto [it, found] = this->lower_bound_and_found(key);
+    auto [it, found] = this->try_find(key);
 
     if (value == nullptr)
     {
@@ -621,7 +621,7 @@ PyObject* SortedDictType::get(PyObject* const* args, Py_ssize_t nargs)
     {
         return nullptr;
     }
-    auto [it, found] = this->lower_bound_and_found(key);
+    auto [it, found] = this->try_find(key);
     if (found)
     {
         return Py_NewRef(it->second.value);  // 🆕
@@ -651,7 +651,7 @@ PyObject* SortedDictType::setdefault(PyObject* const* args, Py_ssize_t nargs)
     {
         return nullptr;
     }
-    auto [it, found] = this->lower_bound_and_found(key);
+    auto [it, found] = this->try_find(key);
     if (found)
     {
         return Py_NewRef(it->second.value);  // 🆕

src/pysorteddict/sorted_dict_type.hh

@@ -69,7 +69,7 @@ private:
     bool is_deletion_allowed(void);
     static bool is_deletion_allowed(Py_ssize_t);
     static bool is_nargs_good(char const*, Py_ssize_t, int, int);
-    std::pair<FwdIterType, bool> lower_bound_and_found(PyObject*);
+    std::pair<FwdIterType, bool> try_find(PyObject*);
     bool update_from_mapping(PyObject*);
     bool update_from_sequence(PyObject*);
     bool update_from_object(PyObject*);