Skip to content

Questionable on WMI calls on CheckForAssignableDevice #4

@shiroinekotfs

Description

@shiroinekotfs

In the CheckDevices(), there are lines that call too much WMI calls.

https://github.com/tfslabs/HyperV-DPD/blob/00896d3b01d8c82ede7c57e8d680c67ade6ab957/CheckForAssignableDevice.xaml.cs#L49-L139

Please take a review. In a case of a Hyper-V cluster, there may be a hundred, or even thousands of PCI devices, with thousands of memory gap zones.

With the current configuration, finding for a loop of that can cause delay, service disruption, connection issue on the client, or even a crash on the WMI system of the server.

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions