NetBSD: Correct a number of symbol link names

Relevant source:

* `devname`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/include/stdlib.h#L296
* `getutent`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/include/utmp.h#L70
* `ntp_gettime`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/sys/sys/timex.h#L257
* `sched_rr_get_interval`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/include/sched.h#L50-L51
* `shmctl`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/sys/sys/shm.h#L2011
* `sig{action,suspend}`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/include/signal.h#L85-L95
* `{get,set}itimer`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/sys/sys/time.h#L331-L335
* `timer_{get,set}time`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/include/time.h#L158-L160
* `utmpx` symbols: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/include/utmpx.h#L135-L150
* `wait4`: https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/sys/sys/wait.h#L209

Excluded are `__statvfs90`, `__fstatvfs90`, `__sigaction_siginfo`,
`__getmntinfo90`, `__getvfsstat90`which are only present in 10.0+ (the
symbol version seems to be N-1). Source:

* https://github.com/NetBSD/src/blob/908770859a5d5141adc63c7844190d01db8a18a4/sys/sys/statvfs.h#L160-L168

There is also a deprecated aliases that used to be needed and is removed
here.

* `__getmntinfo13`:  https://github.com/NetBSD/src/blob/62c785e59d064070166dab5d2a4492055effba89/lib/libc/compat/gen/compat___getmntinfo13.c#L49-L50

(backport <rust-lang#4782>)
(cherry picked from commit 1816f60)

Author: tgross35

libc-test/build.rs

@@ -1465,6 +1465,15 @@ fn test_netbsd(target: &str) {
         }
     });
 
+    cfg.skip_fn_ptrcheck(move |func| {
+        match func {
+            // New symbol version present in NetBSD10, but we keep the old versions for NetBSD9
+            // compatibility.
+            "getmntinfo" | "statvfs" | "fstatvfs" | "getvfsstat" | "sigaction" => true,
+            _ => false,
+        }
+    });
+
     cfg.skip_struct_field_type(move |struct_, field| {
         // This is a weird union, don't check the type.
         (struct_.ident() == "ifaddrs" && field.ident() == "ifa_ifu") ||

src/new/netbsd/sys/timex.rs

@@ -89,6 +89,7 @@ s! {
 }
 
 extern "C" {
+    #[link_name = "__ntp_gettime50"]
     pub fn ntp_gettime(buf: *mut ntptimeval) -> c_int;
     pub fn ntp_adjtime(buf: *mut timex) -> c_int;
 }

src/new/netbsd/utmp_.rs

@@ -27,6 +27,7 @@ s! {
 extern "C" {
     pub fn utmpname(file: *const c_char) -> c_int;
     pub fn setutent();
+    #[link_name = "__getutent50"]
     pub fn getutent() -> *mut utmp;
     pub fn endutent();
 }

src/new/netbsd/utmpx_.rs

@@ -67,16 +67,26 @@ extern "C" {
     pub fn setutxent();
     pub fn endutxent();
 
+    #[link_name = "__getutxent50"]
     pub fn getutxent() -> *mut utmpx;
+    #[link_name = "__getutxid50"]
     pub fn getutxid(ut: *const utmpx) -> *mut utmpx;
+    #[link_name = "__getutxline50"]
     pub fn getutxline(ut: *const utmpx) -> *mut utmpx;
+    #[link_name = "__pututxline50"]
     pub fn pututxline(ut: *const utmpx) -> *mut utmpx;
 
+    #[link_name = "__updwtmpx50"]
     pub fn updwtmpx(file: *const c_char, ut: *const utmpx) -> c_int;
+    #[link_name = "__getlastlogx50"]
     pub fn getlastlogx(fname: *const c_char, uid: crate::uid_t, ll: *mut lastlogx)
         -> *mut lastlogx;
+
+    #[link_name = "__updlastlogx50"]
     pub fn updlastlogx(fname: *const c_char, uid: crate::uid_t, ll: *mut lastlogx) -> c_int;
+    #[link_name = "__getutmp50"]
     pub fn getutmp(ux: *const utmpx, u: *mut crate::utmp);
+    #[link_name = "__getutmpx50"]
     pub fn getutmpx(u: *const crate::utmp, ux: *mut utmpx);
     pub fn utmpxname(file: *const c_char) -> c_int;
 }

src/unix/bsd/mod.rs

@@ -730,6 +730,7 @@ extern "C" {
     )]
     #[cfg_attr(target_os = "netbsd", link_name = "__sigaltstack14")]
     pub fn sigaltstack(ss: *const stack_t, oss: *mut stack_t) -> c_int;
+    #[cfg_attr(target_os = "netbsd", link_name = "__sigsuspend14")]
     pub fn sigsuspend(mask: *const crate::sigset_t) -> c_int;
     pub fn sem_close(sem: *mut sem_t) -> c_int;
     pub fn getdtablesize() -> c_int;
@@ -804,6 +805,7 @@ extern "C" {
         all(target_os = "freebsd", any(freebsd12, freebsd11, freebsd10)),
         link_name = "wait4@FBSD_1.0"
     )]
+    #[cfg_attr(target_os = "netbsd", link_name = "__wait450")]
     pub fn wait4(
         pid: crate::pid_t,
         status: *mut c_int,
@@ -814,11 +816,13 @@ extern "C" {
         all(target_os = "macos", target_arch = "x86"),
         link_name = "getitimer$UNIX2003"
     )]
+    #[cfg_attr(target_os = "netbsd", link_name = "__getitimer50")]
     pub fn getitimer(which: c_int, curr_value: *mut crate::itimerval) -> c_int;
     #[cfg_attr(
         all(target_os = "macos", target_arch = "x86"),
         link_name = "setitimer$UNIX2003"
     )]
+    #[cfg_attr(target_os = "netbsd", link_name = "__setitimer50")]
     pub fn setitimer(
         which: c_int,
         new_value: *const crate::itimerval,
@@ -879,6 +883,7 @@ extern "C" {
         locale: crate::locale_t,
     ) -> size_t;
 
+    #[cfg_attr(target_os = "netbsd", link_name = "__devname50")]
     pub fn devname(dev: crate::dev_t, mode_t: crate::mode_t) -> *mut c_char;
 
     pub fn issetugid() -> c_int;

src/unix/bsd/netbsdlike/mod.rs

@@ -749,6 +749,7 @@ extern "C" {
     pub fn shmget(key: crate::key_t, size: size_t, shmflg: c_int) -> c_int;
     pub fn shmat(shmid: c_int, shmaddr: *const c_void, shmflg: c_int) -> *mut c_void;
     pub fn shmdt(shmaddr: *const c_void) -> c_int;
+    #[cfg_attr(target_os = "netbsd", link_name = "__shmctl50")]
     pub fn shmctl(shmid: c_int, cmd: c_int, buf: *mut crate::shmid_ds) -> c_int;
 
     // DIFF(main): changed to `*const *mut` in e77f551de9

src/unix/bsd/netbsdlike/netbsd/mod.rs

@@ -2124,7 +2124,9 @@ extern "C" {
     ) -> c_int;
     pub fn timer_delete(timerid: crate::timer_t) -> c_int;
     pub fn timer_getoverrun(timerid: crate::timer_t) -> c_int;
+    #[link_name = "__timer_gettime50"]
     pub fn timer_gettime(timerid: crate::timer_t, curr_value: *mut crate::itimerspec) -> c_int;
+    #[link_name = "__timer_settime50"]
     pub fn timer_settime(
         timerid: crate::timer_t,
         flags: c_int,
@@ -2150,6 +2152,7 @@ extern "C" {
         flags: c_int,
     ) -> *mut c_void;
 
+    #[link_name = "__sched_rr_get_interval50"]
     pub fn sched_rr_get_interval(pid: crate::pid_t, t: *mut crate::timespec) -> c_int;
     pub fn sched_setparam(pid: crate::pid_t, param: *const crate::sched_param) -> c_int;
     pub fn sched_getparam(pid: crate::pid_t, param: *mut crate::sched_param) -> c_int;
@@ -2192,7 +2195,6 @@ extern "C" {
         ntargets: size_t,
         hint: *const c_void,
     ) -> c_int;
-    #[link_name = "__getmntinfo13"]
     pub fn getmntinfo(mntbufp: *mut *mut crate::statvfs, flags: c_int) -> c_int;
     pub fn getvfsstat(buf: *mut crate::statvfs, bufsize: size_t, flags: c_int) -> c_int;
 
@@ -2239,7 +2241,7 @@ extern "C" {
 
 #[link(name = "util")]
 extern "C" {
-    #[cfg_attr(target_os = "netbsd", link_name = "__getpwent_r50")]
+    #[link_name = "__getpwent_r50"]
     pub fn getpwent_r(
         pwd: *mut crate::passwd,
         buf: *mut c_char,

src/unix/mod.rs

@@ -1646,6 +1646,7 @@ cfg_if! {
         target_os = "aix",
     )))] {
         extern "C" {
+            #[cfg_attr(target_os = "netbsd", link_name = "__adjtime50")]
             #[cfg_attr(gnu_time_bits64, link_name = "__adjtime64")]
             pub fn adjtime(delta: *const timeval, olddelta: *mut timeval) -> c_int;
         }