Skip to content

Commit ceb2ecf

Browse files
authored
Merge pull request #730 from Drulikar/antilabeling
Do not test merge labeling
2 parents e313d01 + dde56be commit ceb2ecf

File tree

4 files changed

+21
-1
lines changed

4 files changed

+21
-1
lines changed

src/components/utils/TestMergeRow.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,16 @@ export default function TestMergeRow({
157157
style={{ backgroundColor: colorMap[pr.state] }}>
158158
{pr.state}
159159
</Badge>
160-
{pr.testmergelabel ? (
160+
{pr.testmergelabel && !pr.antitestmergelabel ? (
161161
<Badge pill className="text-white text-capitalize mr-2" variant="primary">
162162
<FormattedMessage id="view.instance.repo.testmergelabel" />
163163
</Badge>
164164
) : null}
165+
{pr.antitestmergelabel ? (
166+
<Badge pill className="text-white text-capitalize mr-2" variant="danger">
167+
<FormattedMessage id="view.instance.repo.antitestmergelabel" />
168+
</Badge>
169+
) : null}
165170
{pr.mergeable === false ? (
166171
<Badge pill className="text-white text-capitalize mr-2" variant="danger">
167172
<FormattedMessage id="view.instance.repo.conflictlabel" />

src/components/views/Instance/Edit/Repository.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -960,6 +960,9 @@ class Repository extends React.Component<IProps, IState> {
960960
if (a.testmergelabel !== b.testmergelabel) {
961961
return a.testmergelabel ? -1 : 1;
962962
}
963+
if (a.antitestmergelabel !== b.antitestmergelabel) {
964+
return a.antitestmergelabel ? -1 : 1;
965+
}
963966
if (a.mergeable !== b.mergeable) {
964967
return a.mergeable ? -1 : 1;
965968
}

src/translations/locales/en.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@
424424
"view.instance.repo.manual.desc": "Use this box to manually test merge a pull/merge request by entering its number and clicking \"Add Test Merge\"",
425425
"view.instance.repo.addmanual": "Add Test Merge",
426426
"view.instance.repo.testmergelabel": "Labelled",
427+
"view.instance.repo.antitestmergelabel": "Block Labelled",
427428
"view.instance.repo.conflictlabel": "Merge Conflict",
428429
"view.instance.repo.norepoinfo": "You lack the permission to display information about the repository",
429430
"view.instance.repo.delete.title": "Delete Repository",

src/utils/GithubClient.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export interface PullRequest {
3535
head: string;
3636
tail: string;
3737
testmergelabel: boolean;
38+
antitestmergelabel: boolean;
3839
mergeable: boolean | null;
3940
}
4041

@@ -230,6 +231,11 @@ const e = new (class GithubClient extends TypedEmitter<IEvents> {
230231
label.name?.toLowerCase().includes("testmerge") ||
231232
label.name?.toLowerCase().includes("test merge")
232233
),
234+
antitestmergelabel: pr.labels.some(
235+
label =>
236+
label.name?.toLowerCase().includes("do not testmerge") ||
237+
label.name?.toLowerCase().includes("do not test merge")
238+
),
233239
mergeable: pr.mergeable
234240
};
235241
}
@@ -254,6 +260,11 @@ const e = new (class GithubClient extends TypedEmitter<IEvents> {
254260
label.name?.toLowerCase().includes("testmerge") ||
255261
label.name?.toLowerCase().includes("test merge")
256262
),
263+
antitestmergelabel: pr.labels.some(
264+
label =>
265+
label.name?.toLowerCase().includes("do not testmerge") ||
266+
label.name?.toLowerCase().includes("do not test merge")
267+
),
257268
mergeable: null
258269
};
259270
}

0 commit comments

Comments
 (0)