Refactor search URL handling and fix edge cases

- Extract hardcoded fallback URL to FALLBACK_SEARCH_URL constant
- Add buildSearchUrl() helper function to eliminate duplication
- Fix processBang() to return fallback URL instead of null for incomplete bangs
- Add test coverage for buildSearchUrl() and edge case scenarios
- Add todo.md with remaining code review recommendations

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: thavelick

public_html/search.js

@@ -1,3 +1,5 @@
+const FALLBACK_SEARCH_URL = "https://lite.duckduckgo.com/lite?q={{{s}}}&kl=us-en";
+
 const bangs = [
   {
     t: "al",
@@ -69,21 +71,25 @@ const bangs = [
   },
 ];
 
+function buildSearchUrl(urlTemplate, searchTerm) {
+  return urlTemplate.replace(/{{{s}}}/g, encodeURIComponent(searchTerm));
+}
+
 function processBang(query) {
   const trimmed = query.trim();
 
   if (trimmed.startsWith("!")) {
     const spaceIndex = trimmed.indexOf(" ");
     if (spaceIndex === -1) {
-      return null;
+      return buildSearchUrl(FALLBACK_SEARCH_URL, trimmed);
     }
 
     const bangTag = trimmed.substring(1, spaceIndex);
     const searchTerm = trimmed.substring(spaceIndex + 1).trim();
 
     const bang = bangs.find((b) => b.t === bangTag);
     if (bang) {
-      return bang.u.replace(/{{{s}}}/g, encodeURIComponent(searchTerm));
+      return buildSearchUrl(bang.u, searchTerm);
     }
   }
   const bangMatch = trimmed.match(/^(.+)\s+(\w+)!$/);
@@ -93,10 +99,10 @@ function processBang(query) {
 
     const bang = bangs.find((b) => b.t === bangTag);
     if (bang) {
-      return bang.u.replace(/{{{s}}}/g, encodeURIComponent(searchTerm));
+      return buildSearchUrl(bang.u, searchTerm);
     }
   }
-  return `https://lite.duckduckgo.com/lite?q=${encodeURIComponent(trimmed)}&kl=us-en`;
+  return FALLBACK_SEARCH_URL.replace(/{{{s}}}/g, encodeURIComponent(trimmed));
 }
 
 function getQueryParam(key, windowObj = window) {
@@ -165,5 +171,6 @@ if (typeof module !== "undefined" && module.exports) {
     performSearch,
     setupUI,
     initialize,
+    buildSearchUrl,
   };
 }

tests/search.spec.js

@@ -4,8 +4,17 @@ const {
   performSearch,
   setupUI,
   initialize,
+  buildSearchUrl,
 } = require("../public_html/search.js");
 
+describe("buildSearchUrl", () => {
+  test("replaces template placeholder with encoded search term", () => {
+    const template = "https://example.com/search?q={{{s}}}";
+    const result = buildSearchUrl(template, "hello world");
+    expect(result).toBe("https://example.com/search?q=hello%20world");
+  });
+});
+
 describe("getQueryParam", () => {
   const originalLocation = global.window?.location;
 
@@ -76,6 +85,13 @@ describe("processBang", () => {
       "https://lite.duckduckgo.com/lite?q=!unknown%20search%20term&kl=us-en",
     );
   });
+
+  test("falls back to DuckDuckGo for bang without search term", () => {
+    const result = processBang("!gh");
+    expect(result).toBe(
+      "https://lite.duckduckgo.com/lite?q=!gh&kl=us-en",
+    );
+  });
 });
 
 describe("performSearch", () => {

todo.md

@@ -0,0 +1,15 @@
+# Code Review Recommendations
+
+## Code Quality Improvements
+3. Add error handling for missing DOM elements in `setupUI()` 
+4. Use descriptive property names instead of `t` and `u` in bangs array
+5. Add bounds checking before accessing DOM elements
+
+## Testing Enhancements
+7. Add test for DOM element not found scenarios in `setupUI()`
+
+## Documentation Updates
+11. Document bang property names (`t` = trigger, `u` = URL) in code comments. Note: bangs should use only a-z characters.
+
+## Optional Enhancements
+13. Consider adding input validation for extremely long queries