fix: improve error handling in resolver with console logging

Author: Olavo Parno

README.md

@@ -8,7 +8,7 @@
 
 | Statements                                                                                      | Branches                                                                                 | Functions                                                                                     | Lines                                                                                 |
 | ----------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------- |
-| ![Statements](https://img.shields.io/badge/statements-87.5%25-yellow.svg?style=flat&logo=jest) | ![Branches](https://img.shields.io/badge/branches-73.17%25-red.svg?style=flat&logo=jest) | ![Functions](https://img.shields.io/badge/functions-81.81%25-yellow.svg?style=flat&logo=jest) | ![Lines](https://img.shields.io/badge/lines-88.11%25-yellow.svg?style=flat&logo=jest) |
+| ![Statements](https://img.shields.io/badge/statements-86.44%25-yellow.svg?style=flat&logo=jest) | ![Branches](https://img.shields.io/badge/branches-68.62%25-red.svg?style=flat&logo=jest) | ![Functions](https://img.shields.io/badge/functions-77.14%25-red.svg?style=flat&logo=jest) | ![Lines](https://img.shields.io/badge/lines-86.91%25-yellow.svg?style=flat&logo=jest) |
 
 ## Table of Contents
 

src/__tests__/index.spec.ts

@@ -89,6 +89,10 @@ describe('useDownloader successes', () => {
 });
 
 describe('useDownloader failures', () => {
+  beforeEach(() => {
+    console.error = jest.fn();
+  });
+
   it('should be defined', () => {
     const { result } = renderHook(() => useDownloader());
     expect(result).toBeDefined();
@@ -200,11 +204,24 @@ describe('useDownloader failures', () => {
     expect(result.current.error).toEqual({ errorMessage: 'Custom error!' });
   });
 
-  it('should start download with error Failed to fetch', async () => {
+  it('should start download with response.ok false and an error from the response', async () => {
     const { result, waitForNextUpdate } = renderHook(() => useDownloader());
 
     global.window.fetch = jest.fn(() =>
-      Promise.reject(new Error('Failed to fetch'))
+      Promise.resolve(
+        new Response(
+          JSON.stringify({
+            error: 'File download not allowed',
+            reason:
+              'User must complete verification before accessing this file.',
+          }),
+          {
+            status: 403,
+            statusText: 'Forbidden',
+            headers: { 'Content-Type': 'application/json' },
+          }
+        )
+      )
     );
 
     expect(result.current.error).toBeNull();
@@ -215,7 +232,12 @@ describe('useDownloader failures', () => {
 
     await waitForNextUpdate();
 
-    expect(result.current.error).toBeNull();
+    expect(console.error).toHaveBeenCalledWith('403 default Forbidden');
+
+    expect(result.current.error).toEqual({
+      errorMessage:
+        '403 - Forbidden: File download not allowed: User must complete verification before accessing this file.',
+    });
   });
 
   describe('Tests with msSaveBlob', () => {

src/index.ts

@@ -22,7 +22,9 @@ export const resolver =
   }: ResolverProps) =>
   (response: Response): Response => {
     if (!response.ok) {
-      throw Error(`${response.status} ${response.type} ${response.statusText}`);
+      console.error(`${response.status} ${response.type} ${response.statusText}`);
+
+      throw response;
     }
 
     if (!response.body) {
@@ -240,23 +242,37 @@ export default function useDownloader(
 
           return clearInterval(intervalId);
         })
-        .catch((err) => {
+        .catch(async (error) => {
           clearAllStateCallback();
-          setError((prevValue) => {
-            const { message } = err;
 
-            if (message !== 'Failed to fetch') {
-              return {
-                errorMessage: err.message,
-              };
+          
+          const errorMessage = await (async () => {
+            if (error instanceof Response) {
+              const contentType = error.headers.get("Content-Type") || "";
+              const isJson = contentType.includes("application/json");
+        
+              const errorBody = isJson
+                ? await error.json().catch(() => null)
+                : await error.text().catch(() => null);
+        
+              return [
+                `${error.status} - ${error.statusText}`,
+                errorBody?.error,
+                errorBody?.reason || (typeof errorBody === "string" ? errorBody : null),
+              ]
+                .filter(Boolean)
+                .join(": ");
             }
-
-            return prevValue;
-          });
-
+        
+            return error?.message || "An unknown error occurred.";
+          })();
+        
+          setError({ errorMessage });
+        
           clearTimeout(timeoutId);
-          return clearInterval(intervalId);
+          clearInterval(intervalId);
         });
+        
     },
     [
       isInProgress,