Add seperate room for policy change notification protection. (#933)

This reverts commit 3d138d9 but we
also modified it to make it stil work.

Author: Gnuxie

src/commands/StatusCommand.tsx

@@ -29,6 +29,7 @@ import {
   MatrixRoomReference,
   StringRoomID,
 } from "@the-draupnir-project/matrix-basic-types";
+import { PolicyChangeNotification } from "../protections/PolicyChangeNotification";
 import { RoomTakedownProtection } from "../protections/RoomTakedown/RoomTakedownProtection";
 import { renderRoomPill } from "@the-draupnir-project/mps-interface-adaptor";
 
@@ -97,13 +98,19 @@ DraupnirInterfaceAdaptor.describeRenderer(DraupnirStatusCommand, {
 });
 
 type DraupnirNotificationRoomsInfo = {
+  readonly policyChangeNotificationRoomID: StringRoomID | undefined;
   readonly roomDiscoveryNotificationRoomID: StringRoomID | undefined;
 };
 
 function extractProtectionNotificationRooms(
   draupnir: Draupnir
 ): DraupnirNotificationRoomsInfo {
   return {
+    policyChangeNotificationRoomID: (
+      draupnir.protectedRoomsSet.protections.findEnabledProtection(
+        PolicyChangeNotification.name
+      ) as PolicyChangeNotification | undefined
+    )?.notificationRoomID,
     roomDiscoveryNotificationRoomID: (
       draupnir.protectedRoomsSet.protections.findEnabledProtection(
         RoomTakedownProtection.name
@@ -151,7 +158,10 @@ export function renderPolicyList(list: WatchedPolicyRoom): DocumentNode {
 }
 
 function renderNotificationRooms(info: StatusInfo): DocumentNode {
-  if (info.roomDiscoveryNotificationRoomID === undefined) {
+  if (
+    info.roomDiscoveryNotificationRoomID === undefined &&
+    info.policyChangeNotificationRoomID === undefined
+  ) {
     return <fragment></fragment>;
   }
   const renderNotificationRoom = (
@@ -172,6 +182,10 @@ function renderNotificationRooms(info: StatusInfo): DocumentNode {
       <b>Notification rooms:</b>
       <br />
       <ul>
+        {renderNotificationRoom(
+          "Policy change",
+          info.policyChangeNotificationRoomID
+        )}
         {renderNotificationRoom(
           "Room discovery",
           info.roomDiscoveryNotificationRoomID

src/protections/PolicyChangeNotification.tsx

@@ -11,6 +11,7 @@
 import {
   AbstractProtection,
   ActionResult,
+  EDStatic,
   Logger,
   Ok,
   PolicyListRevision,
@@ -20,7 +21,7 @@ import {
   PolicyRuleMatchType,
   ProtectedRoomsSet,
   ProtectionDescription,
-  UnknownConfig,
+  StringRoomIDSchema,
   describeProtection,
   isError,
 } from "matrix-protection-suite";
@@ -40,15 +41,31 @@ import {
   DocumentNode,
 } from "@the-draupnir-project/interface-manager";
 import { renderRuleHashes, renderRuleClearText } from "../commands/Rules";
+import { NotificationRoomCreator } from "./NotificationRoom/NotificationRoom";
+import { Type } from "@sinclair/typebox";
+import { Result } from "@gnuxie/typescript-result";
 
 const log = new Logger("PolicyChangeNotification");
 
+const PolicyChangeNotificationSettings = Type.Object({
+  notificationRoomID: Type.Optional(
+    Type.Union([StringRoomIDSchema, Type.Undefined()], {
+      default: undefined,
+      description: "The room where notifications should be sent.",
+    })
+  ),
+});
+
+export type PolicyChangeNotificationSettings = EDStatic<
+  typeof PolicyChangeNotificationSettings
+>;
+
 export type PolicyChangeNotificationCapabilitites = Record<never, never>;
 
 export type PolicyChangeNotificationProtectionDescription =
   ProtectionDescription<
     Draupnir,
-    UnknownConfig,
+    typeof PolicyChangeNotificationSettings,
     PolicyChangeNotificationCapabilitites
   >;
 
@@ -62,7 +79,8 @@ export class PolicyChangeNotification
     description: PolicyChangeNotificationProtectionDescription,
     capabilities: PolicyChangeNotificationCapabilitites,
     protectedRoomsSet: ProtectedRoomsSet,
-    private readonly draupnir: Draupnir
+    private readonly draupnir: Draupnir,
+    public readonly notificationRoomID: StringRoomID
   ) {
     super(description, capabilities, protectedRoomsSet, {});
   }
@@ -92,7 +110,7 @@ export class PolicyChangeNotification
     }
     const sendResult = await sendMatrixEventsFromDeadDocument(
       this.draupnir.clientPlatform.toRoomMessageSender(),
-      this.draupnir.managementRoomID,
+      this.notificationRoomID,
       <root>{renderGroupedChanges(groupedChanges.ok)}</root>,
       {}
     );
@@ -159,24 +177,40 @@ function renderGroupedChanges(groupedChanges: GroupedChange[]): DocumentNode {
   return <fragment>{groupedChanges.map(renderListChanges)}</fragment>;
 }
 
-describeProtection<PolicyChangeNotificationCapabilitites, Draupnir>({
+describeProtection<
+  PolicyChangeNotificationCapabilitites,
+  Draupnir,
+  typeof PolicyChangeNotificationSettings
+>({
   name: PolicyChangeNotification.name,
   description: "Provides notification of policy changes from watched lists.",
   capabilityInterfaces: {},
   defaultCapabilities: {},
+  configSchema: PolicyChangeNotificationSettings,
   async factory(
     description,
     protectedRoomsSet,
     draupnir,
     capabilities,
-    _settings
+    settings
   ) {
+    if (settings.notificationRoomID === undefined) {
+      return (await NotificationRoomCreator.createNotificationRoomFromDraupnir(
+        draupnir,
+        description as unknown as ProtectionDescription,
+        settings,
+        "notificationRoomID",
+        "Policy Change Notifications",
+        log
+      )) as Result<PolicyChangeNotification>;
+    }
     return Ok(
       new PolicyChangeNotification(
         description,
         capabilities,
         protectedRoomsSet,
-        draupnir
+        draupnir,
+        settings.notificationRoomID
       )
     );
   },