-
-
Notifications
You must be signed in to change notification settings - Fork 311
WIP apollo-client v4 #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WIP apollo-client v4 #2355
Conversation
Work in process to migrate to the future apollo-client v4 and its native RxJS support via apollographql/apollo-client#12384
|
💻 Website PreviewThe latest changes are available as preview in: https://29013a7b.apollo-angular.pages.dev |
@PowerKiKi FYI we released a codemod with Apollo Client 4.0 that I think might be useful to you here. It not only updates the import locations, but will update to the new types as well (i.e. |
return new Observable(subscriber => { | ||
return obsQuery.subscribe(subscriber); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI ObservableQuery
implements the InteropObservable
interface, so you should be able to simplify this to:
import { from } from "rxjs";
// ...
return from(obsQuery);
I started a v4 branch to continue these changes in #2372. I'd like to do a bit more with that, but figured I'd open what I have finished so we can start a discussion on some of those changes 🙂 |
Work in process to migrate to the future apollo-client v4 and its native RxJS support via apollographql/apollo-client#12384