fix: update sorting for strikes / notes & change infraction embed

Author: ddivad195

src/main/kotlin/me/ddivad/judgebot/embeds/InfractionEmbeds.kt

@@ -18,10 +18,13 @@ fun EmbedBuilder.createInfractionEmbed(guild: Guild, configuration: GuildConfigu
 
 fun EmbedBuilder.createWarnEmbed(guild: Guild, configuration: GuildConfiguration, user: User, guildMember: GuildMember, infraction: Infraction, rule: Rule?) {
     title = "Warn"
-    description = """
-                    | ${user.mention}, you have received a **warning** from **${guild.name}**. A warning is a way for staff to inform you that your behaviour needs to change or further infractions will follow.
-                    | If you think this to be unjustified, please **do not** post about it in a public channel but take it up with **Modmail**.
-                """.trimMargin()
+    description = "${user.mention}, you have received a **warning** from **${guild.name}**."
+
+    field {
+        name = "__Reason__"
+        value = infraction.reason
+        inline = false
+    }
 
     if (infraction.ruleNumber != null) {
         field {
@@ -30,12 +33,6 @@ fun EmbedBuilder.createWarnEmbed(guild: Guild, configuration: GuildConfiguration
         }
     }
 
-    field {
-        name = "__Reason__"
-        value = infraction.reason
-        inline = true
-    }
-
     if (configuration.infractionConfiguration.warnPoints > 0) {
         field {
             name = "__Points__"
@@ -50,6 +47,14 @@ fun EmbedBuilder.createWarnEmbed(guild: Guild, configuration: GuildConfiguration
         }
     }
 
+    field {
+        name = ""
+        value = """
+            A warning is a way for staff to inform you that your behaviour needs to change or further infractions will follow.
+            If you think this to be unjustified, please **do not** post about it in a public channel but DM **Modmail**.
+        """.trimIndent()
+    }
+
     color = Color.RED
     thumbnail {
         url = guild.getIconUrl(Image.Format.PNG) ?: ""

src/main/kotlin/me/ddivad/judgebot/embeds/UserEmbeds.kt

@@ -76,7 +76,8 @@ private suspend fun MenuBuilder.buildOverviewPage(
         getStatus(guild, target, databaseService)?.let { addField("Status", it) }
 
         if (userRecord.infractions.size > 0) {
-            val lastInfraction = userRecord.infractions[userRecord.infractions.size - 1]
+            val lastInfraction = userRecord.infractions.sortedByDescending { it.dateTime }[0]
+
             addField(
                     "**__Most Recent Infraction__**",
                     "Type: **${lastInfraction.type} (${lastInfraction.points})**\n " +
@@ -106,8 +107,8 @@ private suspend fun MenuBuilder.buildInfractionPage(
         thumbnail {
             url = target.asUser().avatar.url
         }
-        val warnings = userRecord.infractions.filter { it.type == InfractionType.Warn }
-        val strikes = userRecord.infractions.filter { it.type == InfractionType.Strike }
+        val warnings = userRecord.infractions.filter { it.type == InfractionType.Warn }.sortedByDescending { it.dateTime }
+        val strikes = userRecord.infractions.filter { it.type == InfractionType.Strike }.sortedByDescending { it.dateTime }
         val bans = userRecord.infractions.filter { it.punishment?.punishment == PunishmentType.BAN }
 
         addInlineField("Warns", "${warnings.size}")
@@ -154,7 +155,7 @@ private suspend fun MenuBuilder.buildNotesPages(
         embedColor: Color,
         totalPages: Int
 ) {
-    val paginatedNotes = userRecord.notes.chunked(4)
+    val paginatedNotes = userRecord.notes.sortedByDescending { it.dateTime }.chunked(4)
     if (userRecord.notes.isEmpty()) {
         page {
             color = embedColor