Skip to content

Commit 1710562

Browse files
committed
Do not test for "dummy" in the interface name.
"dummy" is indeed the default prefix for Linux dummy network interfaces. As far as libpcap is concerned, it is not different from other network interfaces, so there is no good reason to skip it. Fortunately, the checks in fad-gifc.c and fad-glifc.c are dead code because Linux uses fad-getad.c.
1 parent 6b6d692 commit 1710562

File tree

2 files changed

+0
-16
lines changed

2 files changed

+0
-16
lines changed

fad-gifc.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -237,14 +237,6 @@ pcapint_findalldevs_interfaces(pcap_if_list_t *devlistp, char *errbuf,
237237
if (!(*ifrp->ifr_name))
238238
break;
239239

240-
/*
241-
* Skip entries that begin with "dummy".
242-
* XXX - what are these? Is this Linux-specific?
243-
* Are there platforms on which we shouldn't do this?
244-
*/
245-
if (strncmp(ifrp->ifr_name, "dummy", 5) == 0)
246-
continue;
247-
248240
/*
249241
* Can we capture on this device?
250242
*/

fad-glifc.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -158,14 +158,6 @@ pcapint_findalldevs_interfaces(pcap_if_list_t *devlistp, char *errbuf,
158158
ifend = (struct lifreq *)(buf + ifc.lifc_len);
159159

160160
for (; ifrp < ifend; ifrp++) {
161-
/*
162-
* Skip entries that begin with "dummy".
163-
* XXX - what are these? Is this Linux-specific?
164-
* Are there platforms on which we shouldn't do this?
165-
*/
166-
if (strncmp(ifrp->lifr_name, "dummy", 5) == 0)
167-
continue;
168-
169161
/*
170162
* Can we capture on this device?
171163
*/

0 commit comments

Comments
 (0)