Skip to content

Commit f570e6b

Browse files
committed
Revert "findalldevstest: temporary test to see if this squelches Valgrind warnings."
This reverts commit 778f2c0. Yes, Illumos (and probably Solaris) may fflush() all the standard I/O streams before exiting, but it doesn't fclose() them, so stuff might not be freed before exiting (but it should be accessible from stdin, stdout, or stderr, so it's at worst a "still reachable" issue - what gives?). There *appears* to be a suppressor for that in the Solaris valgrind, but it doesn't seem to be working.
1 parent bfb4425 commit f570e6b

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

testprogs/findalldevstest.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,6 @@ int main(int argc _U_, char **argv _U_)
183183
}
184184

185185
pcap_freealldevs(alldevs);
186-
//
187-
// XXX - temporary hack to see if this squelches Valgrind warnings
188-
// on Illumos about leaks from stdio.
189-
//
190-
fclose(stdout);
191186
exit(exit_status);
192187
}
193188

0 commit comments

Comments
 (0)