Skip to content

Commit 57a7eae

Browse files
committed
pgm: expand the comment about PGMCC ACKs. [skip ci]
Apparently there is at least one implementation (Luigi Risso's) that uses 0x0b for ACK, and at least one implementation (OpenPGM) that uses 0x0d for ACK.
1 parent 09b0447 commit 57a7eae

File tree

1 file changed

+21
-3
lines changed

1 file changed

+21
-3
lines changed

print-pgm.c

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,27 @@
2525
an *insufficient* description of said changes. In particular,
2626
it doesn't indicate what the packet type code for ACK is.
2727
28-
This uses 0x0b as the packet type code; Wireshark uses 0x0d.
29-
At least one capture appears to use 0x0d, so we use *both*,
30-
treating *either one* as a PGMCC ACK. */
28+
Luigi Risso's PGMCC code for FreeBSD, at
29+
30+
https://web.archive.org/web/20020302084503/http://info.iet.unipi.it/~luigi/pgm-code/
31+
32+
uses 0x0b (11) for ACK.
33+
34+
A capture file attached to
35+
36+
https://gitlab.com/wireshark/wireshark/-/issues/4798
37+
38+
has packets that use 0x0d for ACK, as does the Wireshark dissector
39+
for PGM, and as does OpenPGM at https://github.com/steve-o/openpgm.
40+
It may be that some proprietary PGMCC implementations, such as
41+
SmartPGM, do so as well.
42+
43+
We use *both*, treating *either one* as a PGMCC ACK, pending
44+
more information, such as an answer to
45+
46+
https://github.com/steve-o/openpgm/issues/75.
47+
48+
*/
3149

3250
#ifdef HAVE_CONFIG_H
3351
#include <config.h>

0 commit comments

Comments
 (0)