Refine bpf_dump(). [skip appveyor]

infrastation · infrastation · commit 5c010dbb2b4d · 2025-02-13T01:34:23.000Z
Constify the temporary pointer, as was done in libpcap in 2008.  Remove
the BDEBUG conditional block becase in libpcap that is a part of the
optimizer debug feature, but in tcpdump it is dead code.
diff --git a/bpf_dump.c b/bpf_dump.c
@@ -31,7 +31,7 @@
 void
 bpf_dump(const struct bpf_program *p, int option)
 {
-	struct bpf_insn *insn;
+	const struct bpf_insn *insn;
 	int i;
 	int n = p->bf_len;
 
@@ -51,10 +51,6 @@ bpf_dump(const struct bpf_program *p, int option)
 		return;
 	}
 	for (i = 0; i < n; ++insn, ++i) {
-#ifdef BDEBUG
-		extern int bids[];
-		printf(bids[i] > 0 ? "[%02d]" : " -- ", bids[i] - 1);
-#endif
 		puts(bpf_image(insn, i));
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`void`
`32`	`32`	`bpf_dump(const struct bpf_program *p, int option)`
`33`	`33`	`{`
`34`		`- struct bpf_insn *insn;`
	`34`	`+ const struct bpf_insn *insn;`
`35`	`35`	`int i;`
`36`	`36`	`int n = p->bf_len;`
`37`	`37`
`@@ -51,10 +51,6 @@ bpf_dump(const struct bpf_program *p, int option)`
`51`	`51`	`return;`
`52`	`52`	`}`
`53`	`53`	`for (i = 0; i < n; ++insn, ++i) {`
`54`		`-#ifdef BDEBUG`
`55`		`- extern int bids[];`
`56`		`- printf(bids[i] > 0 ? "[%02d]" : " -- ", bids[i] - 1);`
`57`		`-#endif`
`58`	`54`	`puts(bpf_image(insn, i));`
`59`	`55`	`}`
`60`	`56`	`}`