NFS: Avoid printing non-ASCII characters

fxlb · fxlb · commit b5353b62c2c5 · 2023-11-01T16:53:09.000+01:00
The "%s" format is a risk (no non-ASCII filtering), thus use
the fn_print_str() function.
diff --git a/print-nfs.c b/print-nfs.c
@@ -904,7 +904,7 @@ nfs_printfh(netdissect_options *ndo,
 
 	if(fsid.Fsid_dev.Minor == 257)
 		/* Print the undecoded handle */
-		ND_PRINT("%s", fsid.Opaque_Handle);
+		fn_print_str(ndo, (const u_char *)fsid.Opaque_Handle);
 	else
 		ND_PRINT("%u", ino);
 }

Original file line number	Diff line number	Diff line change
`@@ -904,7 +904,7 @@ nfs_printfh(netdissect_options *ndo,`
`904`	`904`
`905`	`905`	`if(fsid.Fsid_dev.Minor == 257)`
`906`	`906`	`/* Print the undecoded handle */`
`907`		`- ND_PRINT("%s", fsid.Opaque_Handle);`
	`907`	`+ fn_print_str(ndo, (const u_char *)fsid.Opaque_Handle);`
`908`	`908`	`else`
`909`	`909`	`ND_PRINT("%u", ino);`
`910`	`910`	`}`