ISAKMP: Avoid reinventing nd_printjn()

fxlb · guyharris · commit c3a05eee64a3 · 2025-02-09T14:00:00.000-08:00
diff --git a/print-isakmp.c b/print-isakmp.c
@@ -1437,10 +1437,8 @@ ikev1_id_print(netdissect_options *ndo, u_char tpay _U_,
 		case IPSECDOI_ID_FQDN:
 		case IPSECDOI_ID_USER_FQDN:
 		    {
-			u_int i;
 			ND_PRINT(" len=%u ", len);
-			for (i = 0; i < len; i++)
-				fn_print_char(ndo, GET_U_1(data + i));
+			nd_printjn(ndo, data, len);
 			len = 0;
 			break;
 		    }

Original file line number	Diff line number	Diff line change
`@@ -1437,10 +1437,8 @@ ikev1_id_print(netdissect_options *ndo, u_char tpay _U_,`
`1437`	`1437`	`case IPSECDOI_ID_FQDN:`
`1438`	`1438`	`case IPSECDOI_ID_USER_FQDN:`
`1439`	`1439`	`{`
`1440`		`- u_int i;`
`1441`	`1440`	`ND_PRINT(" len=%u ", len);`
`1442`		`- for (i = 0; i < len; i++)`
`1443`		`- fn_print_char(ndo, GET_U_1(data + i));`
	`1441`	`+ nd_printjn(ndo, data, len);`
`1444`	`1442`	`len = 0;`
`1445`	`1443`	`break;`
`1446`	`1444`	`}`