feat: allow dashes and ensure that first char in name is ascii alphabetic (#73)

* feat: allow dashes and ensure that first char in name is ascii alphabetic

* fix: allow dashes in test

* fix: test dash at front

Author: willemneal

contracts/registry/src/error.rs

@@ -27,7 +27,10 @@ pub enum Error {
     /// New version must be greater than the most recent version
     VersionMustBeGreaterThanCurrent = 11,
     /// Invalid name.
-    /// Must be 64 characters or less; ascii alphanumeric or '_'; start with a letter; and not be a Rust keyword
+    /// Must be 64 characters or less;
+    /// ascii alphanumeric, '-', or '_';
+    /// start with a ascii alphabetic character;
+    /// and not be a Rust keyword
     InvalidName = 12,
     /// Invalid Version. Must be valid cargo version
     InvalidVersion = 13,

contracts/registry/src/name.rs

@@ -12,10 +12,11 @@ pub(crate) fn is_valid(s: &String) -> bool {
     let Ok(s) = core::str::from_utf8(first) else {
         return false;
     };
-    if is_keyword(s) || s.starts_with(|c: char| c == '_' || c.is_numeric()) {
+    if is_keyword(s) || !s.starts_with(|c: char| c.is_ascii_alphabetic()) {
         return false;
     }
-    s.chars().all(|c| c.is_ascii_alphanumeric() || c == '_')
+    s.chars()
+        .all(|c| c.is_ascii_alphanumeric() || c == '_' || c == '-')
 }
 
 pub(crate) fn validate(s: &String) -> Result<(), Error> {

contracts/registry/src/test.rs

@@ -125,8 +125,10 @@ fn validate_names() {
         "abcdefghabcdefghabcdefghabcdefghabcdefghabcdefghabcdefghabcdefgha",
         false,
     );
-    test_string("a-a_b", false);
+    test_string("a-a_b", true);
+    test_string("a-a]]]_b", false);
     test_string("_ab", false);
+    test_string("-ab", false);
     test_string("1ab", false);
 }