REG-33 – sort out timings; separate email delivery wait from UI pauses

Author: NoelLH

features/donation-as-new-donor-restart-donation.feature

@@ -19,6 +19,7 @@ Feature: New donor: restarting donation completes successfully
         And I press Donate
         When I wait a few seconds
         Then I should be redirected to a Thank You confirmation page with the correct amount
+        When I wait long enough for email processing
         Then my last email should contain the correct amounts
         And my last email should contain the charity's custom thank you message
-        And my last email should contain the correct name
+        And my last email should contain the correct name

features/donation-as-new-donor-then-register.feature

@@ -14,12 +14,13 @@ Feature: New donor: donation completes successfully and donor registers
         And I press Donate
         When I wait a few seconds
         Then I should be redirected to a Thank You confirmation page with the correct amount
+        When I wait long enough for email processing
         Then my last email should contain the correct amounts
         And my last email should contain the charity's custom thank you message
         And my last email should contain the correct name
         When I press on the button to set a password
         And I enter my new password
         And I press on the button to create an account
         Then the page should update to say I'm registered
-        When I wait a few seconds
+        When I wait long enough for email processing
         Then I should recieve a registration success email with the email I donated with

features/donation-with-credits.feature

@@ -24,6 +24,7 @@ Feature: Existing donor: credit donation completes successfully
         And I press Donate
         When I wait a few seconds
         Then I should be redirected to a Thank You confirmation page with the correct amount
+        When I wait long enough for email processing
         Then my last email should contain the correct amounts
         And my last email should contain the charity's custom thank you message
-        And my last email should contain the correct name
+        And my last email should contain the correct name

features/submit-pledge.feature

@@ -23,5 +23,6 @@ Feature: Pledge form is submitted successfully
     When I wait a few seconds
     Then I should see a Communities card with heading "Thank you!"
     And the main card text should start with confirmation of my chosen pledge amount and the correct charity name
+    When I wait long enough for email processing
     Then my last email subject should contain "Thank you for your pledge"
     And my last email should contain my pledged amount

pages/DonateStartPage.js

@@ -148,10 +148,10 @@ export default class DonateStartPage {
 
     /**
      * set amount value
-     * @param {int} amount number
+     * @param {number} amount
      */
     async setDonationAmount(amount) {
-        await inputSelectorValue(donationAmountSelector, amount);
+        await inputSelectorValue(donationAmountSelector, amount.toString());
         // Leave tip at select dropdown's default if in Stripe mode and that field exists.
     }
 
@@ -331,7 +331,9 @@ export default class DonateStartPage {
      * incompletes.
      */
     async checkNoAccessibilityViolations() {
-        return; //  todo reinstate when known a11y problems fixed.
+        // todo reinstate when known a11y problems fixed, via
+        // https://github.com/thebiggive/donate-frontend/pull/1325 and maybe others
+        return;
 
         /* eslint-disable no-unreachable */
 

steps/donation.js

@@ -221,10 +221,10 @@ When(
 );
 
 When(
-    'I wait 45 seconds',
-    // 45s to allow SF + Mailtrap time to process everything
+    'I wait long enough for email processing',
+    // 35s to allow SF + Mailtrap time to process everything
     // eslint-disable-next-line wdio/no-pause
-    async () => browser.pause(45 * 1000)
+    async () => browser.pause(35 * 1000)
 );
 
 Then(