Fix

Fix

Author: codewithtamim

IMPLEMENTATION_SUMMARY.md

@@ -60,11 +60,9 @@ class ConvertItService : Service() {
         super.onDestroy()
         Log.i(TAG, "Service destroyed")
 
-        // Cancel ongoing conversion job
         conversionJob?.cancel()
         conversionJob = null
 
-        // Cancel all FFmpeg sessions
         FFmpegKit.cancel()
         Log.i(TAG, "Cancelled all FFmpeg sessions in onDestroy")
     }
@@ -87,11 +85,9 @@ class ConvertItService : Service() {
         if (intent?.action == ACTION_STOP_SERVICE) {
             Log.i(TAG, "Stopping service as per user request. startId: $startId")
 
-            // Cancel ongoing conversion job
             conversionJob?.cancel()
             conversionJob = null
 
-            // Cancel all FFmpeg sessions
             FFmpegKit.cancel()
             Log.i(TAG, "Cancelled all FFmpeg sessions")
 

app/src/main/java/com/nasahacker/convertit/service/ConvertItService.kt

@@ -187,10 +187,9 @@ fun HomeScreen(
         audioUri = metadataUri,
         onDismissRequest = { 
             showMetadataDialog = false
-            viewModel.setMetadataUri(null) // Clear the URI
+            viewModel.setMetadataUri(null)
         },
         onMetadataSaved = {
-            // Optionally refresh or update UI after metadata is saved
         }
     )
 }

app/src/main/java/com/nasahacker/convertit/ui/screen/HomeScreen.kt

@@ -45,7 +45,6 @@ class AppViewModel : ViewModel() {
             val isSuccess = intent?.getBooleanExtra(IS_SUCCESS, false) == true
             viewModelScope.launch {
                 _conversionStatus.value = isSuccess
-                // Clear URI list regardless of success or failure
                 clearUriList()
             }
         }

app/src/main/java/com/nasahacker/convertit/ui/viewmodel/AppViewModel.kt

@@ -47,6 +47,7 @@ import com.nasahacker.convertit.dto.Metadata
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.withContext
 import java.io.ByteArrayOutputStream
+import androidx.core.content.edit
 
 /**
  * @author Tamim Hossain
@@ -325,18 +326,18 @@ object AppUtil {
 
     fun saveCustomSaveLocation(context: Context, uri: Uri) {
         val sharedPrefs = context.getSharedPreferences(APP_PREF, Context.MODE_PRIVATE)
-        sharedPrefs.edit().putString(PREF_CUSTOM_SAVE_LOCATION, uri.toString()).apply()
+        sharedPrefs.edit { putString(PREF_CUSTOM_SAVE_LOCATION, uri.toString()) }
     }
 
     fun getCustomSaveLocation(context: Context): Uri? {
         val sharedPrefs = context.getSharedPreferences(APP_PREF, Context.MODE_PRIVATE)
         val uriString = sharedPrefs.getString(PREF_CUSTOM_SAVE_LOCATION, null)
-        return uriString?.let { Uri.parse(it) }
+        return uriString?.toUri()
     }
 
     fun clearCustomSaveLocation(context: Context) {
         val sharedPrefs = context.getSharedPreferences(APP_PREF, Context.MODE_PRIVATE)
-        sharedPrefs.edit().remove(PREF_CUSTOM_SAVE_LOCATION).apply()
+        sharedPrefs.edit { remove(PREF_CUSTOM_SAVE_LOCATION) }
     }
 
     fun getCurrentSaveLocationPath(context: Context): String {