Skip to content

Commit 8d5f39f

Browse files
committed
HOTFIX : Disable tini (didn't work properly with arm)
1 parent 5e2ca66 commit 8d5f39f

File tree

6 files changed

+26
-27
lines changed

6 files changed

+26
-27
lines changed

Dockerfile.slim.apache

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -294,12 +294,12 @@ RUN sed -i 's#/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin#/usr/
294294

295295
ENV IMAGE_VARIANT=apache
296296

297-
# Add Tini (to be able to stop the container with ctrl-c).
298-
# See: https://github.com/krallin/tini
299-
# FIX https://github.com/krallin/tini/pull/67
300-
ENV TINI_VERSION v0.19.0
301-
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
302-
RUN chmod +x /tini
297+
## Add Tini (to be able to stop the container with ctrl-c).
298+
## See: https://github.com/krallin/tini
299+
## FIX https://github.com/krallin/tini/pull/67
300+
#ENV TINI_VERSION v0.19.0
301+
#ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
302+
#RUN chmod +x /tini
303303

304304
COPY utils/generate_cron.php /usr/local/bin/generate_cron.php
305305
COPY utils/startup_commands.php /usr/local/bin/startup_commands.php

Dockerfile.slim.cli

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,12 +220,12 @@ RUN sed -i 's#/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin#/usr/
220220

221221
ENV IMAGE_VARIANT=cli
222222

223-
# Add Tini (to be able to stop the container with ctrl-c).
224-
# See: https://github.com/krallin/tini
225-
# FIX https://github.com/krallin/tini/pull/67
226-
ENV TINI_VERSION v0.19.0
227-
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
228-
RUN chmod +x /tini
223+
## Add Tini (to be able to stop the container with ctrl-c).
224+
## See: https://github.com/krallin/tini
225+
## FIX https://github.com/krallin/tini/pull/67
226+
#ENV TINI_VERSION v0.19.0
227+
#ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
228+
#RUN chmod +x /tini
229229

230230
COPY utils/generate_cron.php /usr/local/bin/generate_cron.php
231231
COPY utils/startup_commands.php /usr/local/bin/startup_commands.php

Dockerfile.slim.fpm

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -233,12 +233,12 @@ RUN sed -i 's#/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin#/usr/
233233

234234
ENV IMAGE_VARIANT=fpm
235235

236-
# Add Tini (to be able to stop the container with ctrl-c).
237-
# See: https://github.com/krallin/tini
238-
# FIX https://github.com/krallin/tini/pull/67
239-
ENV TINI_VERSION v0.19.0
240-
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
241-
RUN chmod +x /tini
236+
## Add Tini (to be able to stop the container with ctrl-c).
237+
## See: https://github.com/krallin/tini
238+
## FIX https://github.com/krallin/tini/pull/67
239+
#ENV TINI_VERSION v0.19.0
240+
#ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
241+
#RUN chmod +x /tini
242242

243243
COPY utils/generate_cron.php /usr/local/bin/generate_cron.php
244244
COPY utils/startup_commands.php /usr/local/bin/startup_commands.php

utils/Dockerfile.slim.blueprint

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -309,12 +309,12 @@ RUN sed -i 's#/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin#/usr/
309309

310310
ENV IMAGE_VARIANT={{ .Orbit.variant }}
311311

312-
# Add Tini (to be able to stop the container with ctrl-c).
313-
# See: https://github.com/krallin/tini
314-
# FIX https://github.com/krallin/tini/pull/67
315-
ENV TINI_VERSION v0.19.0
316-
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
317-
RUN chmod +x /tini
312+
## Add Tini (to be able to stop the container with ctrl-c).
313+
## See: https://github.com/krallin/tini
314+
## FIX https://github.com/krallin/tini/pull/67
315+
#ENV TINI_VERSION v0.19.0
316+
#ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-${TARGETARCH} /tini
317+
#RUN chmod +x /tini
318318

319319
COPY utils/generate_cron.php /usr/local/bin/generate_cron.php
320320
COPY utils/startup_commands.php /usr/local/bin/startup_commands.php

utils/docker-entrypoint.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22

33
set -e
44

5-
exec "sudo" "-E" "/tini" "-g" "-s" "--" "/usr/local/bin/docker-entrypoint-as-root.sh" "$@";
5+
#exec "sudo" "-E" "/tini" "-g" "-s" "--" "/usr/local/bin/docker-entrypoint-as-root.sh" "$@";
6+
exec "sudo" "-E" "/usr/local/bin/docker-entrypoint-as-root.sh" "$@";

utils/generate_cron.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* The script is run on each start of the container.
55
*/
66

7-
$tiniPid = $argv[1];
8-
97
$found = false;
108

119
foreach ($_SERVER as $key => $command) {

0 commit comments

Comments
 (0)