Skip to content

Commit f9be18a

Browse files
committed
Missing uploadprogress
1 parent 742231b commit f9be18a

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

Makefile

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ _test-prerequisites: blueprint
1010
docker pull ubuntu:20.04
1111

1212
test-quick: ## Test 8.0 and 8.1 quickly
13-
VERSION=8.0 VARIANT=cli $(MAKE) _test-version
14-
VERSION=8.1 VARIANT=cli $(MAKE) _test-version
13+
VERSION=8.0 VARIANT=cli $(MAKE) _test-version-quick
14+
VERSION=8.1 VARIANT=cli $(MAKE) _test-version-quick
1515

1616
test-8.1: ## Test php8.1 build only
1717
VERSION=8.1 VARIANT=cli $(MAKE) _test-version
@@ -30,5 +30,12 @@ _test-version: _test-prerequisites ## Test php build for VERSION="" and VARIANT=
3030
PHP_VERSION="$(VERSION)" BRANCH=v4 VARIANT=$(VARIANT) ./tests-suite/bash_unit -f tap ./tests-suite/*.sh || (notify-send -u critical "Tests failed ($(VERSION)-$(VARIANT))" && exit 1)
3131
notify-send -u critical "Tests passed with success ($(VERSION)-$(VARIANT))"
3232

33+
_test-version-quick: _test-prerequisites ## Test php build for VERSION="" and VARIANT="" (without node variants)
34+
docker buildx bake --load \
35+
--set "*.platform=$$(uname -p)" \
36+
php$${VERSION//.}-slim-$(VARIANT) php$${VERSION//.}-$(VARIANT)
37+
PHP_VERSION="$(VERSION)" BRANCH=v4 VARIANT=$(VARIANT) ./tests-suite/bash_unit -f tap ./tests-suite/*.sh || (notify-send -u critical "Tests failed ($(VERSION)-$(VARIANT))" && exit 1)
38+
notify-send -u critical "Tests passed with success ($(VERSION)-$(VARIANT)) - without node-*"
39+
3340
clean: ## Clean dangles image after build
3441
rm -rf /tmp/buildx-cache
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
#!/usr/bin/env bash
22

33
set -e
4-
export PECL_EXTENSION=uploadprogress
4+
#if [[ "${PHP_VERSION}" =~ ^7 ]]; then
5+
# export PECL_EXTENSION=uploadprogress
6+
#else
7+
export EXTENSION=uploadprogress
8+
#fi
59

610
../docker-install.sh

tests-suite/php-extensions.sh

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@ test_presenceOfPDO() {
1717
RESULT=$(docker run ${RUN_OPTIONS} --rm "${REPO}:${TAG_PREFIX}${PHP_VERSION}-${BRANCH}-slim-${BRANCH_VARIANT}" php -m | tail -n +1 | grep --color=never PDO)
1818
assert_equals "PDO" "${RESULT}" "Missing php-PDO"
1919
}
20+
#################################################################
21+
## Let's check that uploadprogress is enabled explicitly with fat
22+
#################################################################
23+
test_presenceOfUploadprogressOnFat() {
24+
RESULT=$(docker run ${RUN_OPTIONS} -e "PHP_EXTENSIONS=uploadprogress" --rm "${REPO}:${TAG_PREFIX}${PHP_VERSION}-${BRANCH}-${BRANCH_VARIANT}" php -m | tail -n +1 | grep --color=never uploadprogress)
25+
assert_equals "uploadprogress" "${RESULT}" "Missing php-uploadprogress"
26+
}
2027
############################################################
2128
## Let's check that the extensions are enabled when composer is run
2229
############################################################

0 commit comments

Comments
 (0)