Skip to content
This repository was archived by the owner on Apr 14, 2024. It is now read-only.

Commit 8fcda3b

Browse files
author
Julien Neuhart
committed
fixing #3
1 parent a829bcc commit 8fcda3b

File tree

4 files changed

+58
-0
lines changed

4 files changed

+58
-0
lines changed

client.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,10 @@ func multipartForm(req Request) (*bytes.Buffer, string, error) {
151151
writer := multipart.NewWriter(body)
152152
defer writer.Close()
153153
for filename, fpath := range req.getFormFiles() {
154+
// https://github.com/thecodingmachine/gotenberg-go-client/issues/3
155+
if fpath == "" {
156+
continue
157+
}
154158
in, err := os.Open(fpath)
155159
if err != nil {
156160
return nil, "", fmt.Errorf("%s: opening file: %v", filename, err)

html_test.go

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,23 @@ func TestHTML(t *testing.T) {
3737
assert.Nil(t, err)
3838
}
3939

40+
func TestHTMLWithoutHeaderFooter(t *testing.T) {
41+
c := &Client{Hostname: "http://localhost:3000"}
42+
req, err := NewHTMLRequest(test.HTMLTestFilePath(t, "index.html"))
43+
require.Nil(t, err)
44+
req.SetPaperSize(A4)
45+
req.SetMargins(NormalMargins)
46+
req.SetLandscape(false)
47+
dirPath, err := test.Rand()
48+
require.Nil(t, err)
49+
dest := fmt.Sprintf("%s/foo.pdf", dirPath)
50+
err = c.Store(req, dest)
51+
assert.Nil(t, err)
52+
assert.FileExists(t, dest)
53+
err = os.RemoveAll(dirPath)
54+
assert.Nil(t, err)
55+
}
56+
4057
func TestConcurrentHTML(t *testing.T) {
4158
for i := 0; i < 10; i++ {
4259
go func() {

markdown_test.go

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,28 @@ func TestMarkdown(t *testing.T) {
4242
assert.Nil(t, err)
4343
}
4444

45+
func TestMarkdownWithoutHeaderFooter(t *testing.T) {
46+
c := &Client{Hostname: "http://localhost:3000"}
47+
req, err := NewMarkdownRequest(
48+
test.MarkdownTestFilePath(t, "index.html"),
49+
test.MarkdownTestFilePath(t, "paragraph1.md"),
50+
test.MarkdownTestFilePath(t, "paragraph2.md"),
51+
test.MarkdownTestFilePath(t, "paragraph3.md"),
52+
)
53+
require.Nil(t, err)
54+
req.SetPaperSize(A4)
55+
req.SetMargins(NormalMargins)
56+
req.SetLandscape(false)
57+
dirPath, err := test.Rand()
58+
require.Nil(t, err)
59+
dest := fmt.Sprintf("%s/foo.pdf", dirPath)
60+
err = c.Store(req, dest)
61+
assert.Nil(t, err)
62+
assert.FileExists(t, dest)
63+
err = os.RemoveAll(dirPath)
64+
assert.Nil(t, err)
65+
}
66+
4567
func TestConcurrentMarkdown(t *testing.T) {
4668
for i := 0; i < 10; i++ {
4769
go func() {

url_test.go

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,22 @@ func TestURL(t *testing.T) {
1717
require.Nil(t, err)
1818
err = req.SetFooter(test.URLTestFilePath(t, "footer.html"))
1919
require.Nil(t, err)
20+
req.SetPaperSize(A4)
21+
req.SetMargins(NormalMargins)
22+
req.SetLandscape(false)
23+
dirPath, err := test.Rand()
2024
require.Nil(t, err)
25+
dest := fmt.Sprintf("%s/foo.pdf", dirPath)
26+
err = c.Store(req, dest)
27+
assert.Nil(t, err)
28+
assert.FileExists(t, dest)
29+
err = os.RemoveAll(dirPath)
30+
assert.Nil(t, err)
31+
}
32+
33+
func TestURLWithoutHeaderFooter(t *testing.T) {
34+
c := &Client{Hostname: "http://localhost:3000"}
35+
req := NewURLRequest("http://google.com")
2136
req.SetPaperSize(A4)
2237
req.SetMargins(NormalMargins)
2338
req.SetLandscape(false)

0 commit comments

Comments
 (0)