Skip to content

Commit 35f01c7

Browse files
authored
Merge pull request #10 from ValdoTR/configuration
Converted namespace controllers and types to array if it's not the case
2 parents 3af7eea + 4ca08c8 commit 35f01c7

File tree

2 files changed

+14
-27
lines changed

2 files changed

+14
-27
lines changed

DependencyInjection/Configuration.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,14 @@ public function getConfigTreeBuilder()
1515

1616
$rootNode->info('Read more about GraphQLite available options at: https://graphqlite.thecodingmachine.io/docs/symfony-bundle')
1717
->children()
18-
//->scalarNode('controllers_namespace')->defaultValue('App\\Controllers')->end()
19-
//->scalarNode('types_namespace')->defaultValue('App\\Types')->end()
20-
->arrayNode('namespace')/*->isRequired()*/
18+
->arrayNode('namespace')
2119
->children()
22-
->arrayNode('controllers')
23-
->requiresAtLeastOneElement()
20+
->arrayNode('controllers')->isRequired()
2421
->beforeNormalization()->castToArray()->end()
22+
->requiresAtLeastOneElement()
2523
->scalarPrototype()->cannotBeEmpty()->end()
2624
->end()
27-
->arrayNode('types')
25+
->arrayNode('types')->isRequired()
2826
->requiresAtLeastOneElement()
2927
->beforeNormalization()->castToArray()->end()
3028
->scalarPrototype()->cannotBeEmpty()->end()

DependencyInjection/GraphqliteExtension.php

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,23 @@ public function load(array $configs, ContainerBuilder $container)
3333
$configuration = new Configuration();
3434
$config = $this->processConfiguration($configuration, $configs);
3535

36-
//$config = $this->processConfiguration($this->getConfiguration($config, $container), $config);
3736
$loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config/container'));
3837

3938
if (isset($configs[0]['namespace']['controllers'])) {
40-
$namespaceController = array_map(function($namespace) { return rtrim($namespace, '\\') . '\\'; }, $configs[0]['namespace']['controllers']);
39+
$controllers = $configs[0]['namespace']['controllers'];
40+
if (!is_array($controllers)) {
41+
$controllers = [ $controllers ];
42+
}
43+
$namespaceController = array_map(function($namespace) { return rtrim($namespace, '\\') . '\\'; }, $controllers);
4144
} else {
4245
$namespaceController = [];
4346
}
4447
if (isset($configs[0]['namespace']['types'])) {
45-
$namespaceType = array_map(function($namespace) { return rtrim($namespace, '\\') . '\\'; }, $configs[0]['namespace']['types']);
48+
$types = $configs[0]['namespace']['types'];
49+
if (!is_array($types)) {
50+
$types = [ $types ];
51+
}
52+
$namespaceType = array_map(function($namespace) { return rtrim($namespace, '\\') . '\\'; }, $types);
4653
} else {
4754
$namespaceType = [];
4855
}
@@ -62,24 +69,6 @@ public function load(array $configs, ContainerBuilder $container)
6269

6370
$container->registerForAutoconfiguration(ObjectType::class)
6471
->addTag('graphql.output_type');
65-
66-
67-
/*$definition = $container->getDefinition(Configuration::class);
68-
$definition->replaceArgument(0, $config['bean_namespace']);
69-
$definition->replaceArgument(1, $config['dao_namespace']);
70-
71-
if (isset($config['naming'])) {
72-
$definitionNamingStrategy = $container->getDefinition(\TheCodingMachine\TDBM\Utils\DefaultNamingStrategy::class);
73-
$definitionNamingStrategy->addMethodCall('setBeanPrefix', [$config['naming']['bean_prefix']]);
74-
$definitionNamingStrategy->addMethodCall('setBeanSuffix', [$config['naming']['bean_suffix']]);
75-
$definitionNamingStrategy->addMethodCall('setBaseBeanPrefix', [$config['naming']['base_bean_prefix']]);
76-
$definitionNamingStrategy->addMethodCall('setBaseBeanSuffix', [$config['naming']['base_bean_suffix']]);
77-
$definitionNamingStrategy->addMethodCall('setDaoPrefix', [$config['naming']['dao_prefix']]);
78-
$definitionNamingStrategy->addMethodCall('setDaoSuffix', [$config['naming']['dao_suffix']]);
79-
$definitionNamingStrategy->addMethodCall('setBaseDaoPrefix', [$config['naming']['base_dao_prefix']]);
80-
$definitionNamingStrategy->addMethodCall('setBaseDaoSuffix', [$config['naming']['base_dao_suffix']]);
81-
$definitionNamingStrategy->addMethodCall('setExceptions', [$config['naming']['exceptions']]);
82-
}*/
8372
}
8473

8574
private function getNamespaceDir(string $namespace): string

0 commit comments

Comments
 (0)