Merge pull request #53 from moufmouf/factory_on_public

moufmouf · web-flow · commit 3f85584344e4 · 2020-01-30T15:33:10.000+01:00
Optimisation: checking only @factory annotation in public methods
diff --git a/DependencyInjection/GraphqliteCompilerPass.php b/DependencyInjection/GraphqliteCompilerPass.php
@@ -194,7 +194,7 @@ public function process(ContainerBuilder $container)
                     if ($typeAnnotation !== null || $this->getAnnotationReader()->getExtendTypeAnnotation($reflectionClass) !== null) {
                         $definition->setPublic(true);
                     }
-                    foreach ($reflectionClass->getMethods() as $method) {
+                    foreach ($reflectionClass->getMethods(ReflectionMethod::IS_PUBLIC) as $method) {
                         $factory = $reader->getFactoryAnnotation($method);
                         if ($factory !== null) {
                             $definition->setPublic(true);

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ public function process(ContainerBuilder $container)`
`194`	`194`	`if ($typeAnnotation !== null \|\| $this->getAnnotationReader()->getExtendTypeAnnotation($reflectionClass) !== null) {`
`195`	`195`	`$definition->setPublic(true);`
`196`	`196`	`}`
`197`		`- foreach ($reflectionClass->getMethods() as $method) {`
	`197`	`+ foreach ($reflectionClass->getMethods(ReflectionMethod::IS_PUBLIC) as $method) {`
`198`	`198`	`$factory = $reader->getFactoryAnnotation($method);`
`199`	`199`	`if ($factory !== null) {`
`200`	`200`	`$definition->setPublic(true);`