Setting globTtl to 2 seconds only in dev env

The globTtl setting (that commands when to do file scans for changed files) is now set to 2 seconds for the "dev" environment and set to null (i.e. cache forever) for other environments.
This should result in a performance boost for production machines (especially if they receive less than 1 request every 2 seconds).

Author: moufmouf

DependencyInjection/GraphqliteCompilerPass.php

@@ -35,6 +35,7 @@
 use TheCodingMachine\GraphQLite\TypeGenerator;
 use TheCodingMachine\GraphQLite\Types\MutableObjectType;
 use TheCodingMachine\GraphQLite\Types\ResolvableInputObjectType;
+use function var_dump;
 
 /**
  * Detects controllers and types automatically and tag them.
@@ -51,29 +52,20 @@ class GraphqliteCompilerPass implements CompilerPassInterface
      */
     public function process(ContainerBuilder $container)
     {
-        /**
-         * @var array<string, string> An array matching class name to the the container identifier of a factory creating a type.
-         */
-        $types = [];
-
-        /**
-         * @var array<string, string> An array matching class name to the the container identifier of a factory creating an input type.
-         */
-        $inputTypes = [];
-
-        /**
-         * @var array<string, string> An array matching a Graphql type name to the the container identifier of a factory creating a type.
-         */
-        $typesByName = [];
-
-        $namingStrategy = new NamingStrategy();
         $reader = $this->getAnnotationReader();
         //$inputTypeUtils = new InputTypeUtils($reader, $namingStrategy);
 
         // Let's scan the whole container and tag the services that belong to the namespace we want to inspect.
         $controllersNamespaces = $container->getParameter('graphqlite.namespace.controllers');
         $typesNamespaces = $container->getParameter('graphqlite.namespace.types');
 
+        // 2 seconds of TTL in environment mode. Otherwise, let's cache forever!
+        $env = $container->getParameter('kernel.environment');
+        $globTtl = null;
+        if ($env === 'dev') {
+            $globTtl = 2;
+        }
+
         foreach ($container->getDefinitions() as $id => $definition) {
             if ($definition->isAbstract() || $definition->getClass() === null) {
                 continue;
@@ -144,73 +136,11 @@ public function process(ContainerBuilder $container)
                 $container->setDefinition($controllerIdentifier, $queryProvider);
             }
         }
-/*
-        foreach ($container->findTaggedServiceIds('graphql.annotated.type') as $id => $tag) {
-            $used = false;
-            $definition = $container->findDefinition($id);
-            $class = $definition->getClass();
-            if ($class === null) {
-                throw new \RuntimeException(sprintf('Service %s has no class defined.', $id));
-            }
-
-            $reflectionClass = new ReflectionClass($class);
-            foreach ($reflectionClass->getMethods() as $method) {
-                $factory = $reader->getFactoryAnnotation($method);
-                if ($factory !== null) {
-                    $objectTypeIdentifier = $class.'__'.$method->getName().'__InputType';
-
-                    $objectType = new Definition(ResolvableInputObjectType::class);
-                    $objectType->setPrivate(false);
-                    $objectType->setFactory([self::class, 'createInputObjectType']);
-                    $objectType->addArgument(new Reference($id));
-                    $objectType->addArgument($method->getName());
-                    $objectType->addArgument(new Reference(InputTypeGenerator::class));
-                    $objectType->addArgument(new Reference(RecursiveTypeMapperInterface::class));
-                    $container->setDefinition($objectTypeIdentifier, $objectType);
-
-                    [$inputName, $inputClassName] = $inputTypeUtils->getInputTypeNameAndClassName($method);
-
-                    $inputTypes[$inputClassName] = $objectTypeIdentifier;
-                    $typesByName[$inputName] = $objectTypeIdentifier;
-
-                    $used = true;
-                }
-            }
-
-            $typeAnnotation = $this->annotationReader->getTypeAnnotation($reflectionClass);
-            if ($typeAnnotation !== null) {
-                $objectTypeIdentifier = $class.'__Type';
-
-                $objectType = new Definition(ObjectType::class);
-                $objectType->setPrivate(false);
-                $objectType->setFactory([self::class, 'createObjectType']);
-                $objectType->addArgument($id);
-                $objectType->addArgument(new Reference(TypeGenerator::class));
-                $objectType->addArgument(new Reference(RecursiveTypeMapperInterface::class));
-                $container->setDefinition($objectTypeIdentifier, $objectType);
-
-                $types[$typeAnnotation->getClass()] = $objectTypeIdentifier;
-                $typesByName[$namingStrategy->getOutputTypeName($class, $typeAnnotation)] = $objectTypeIdentifier;
-                //$definition->addTag('graphql.annotated_type');
-
-                $used = true;
-            }
-
-            // If the service is used for GraphQL, since it is referenced by service name in the factories, let's make it public
-            if ($used) {
-                $container->findDefinition($id)->setPublic(true);
-            }
-        }
-
-        $containerFetcherTypeMapper = $container->getDefinition(ContainerFetcherTypeMapper::class);
-        $containerFetcherTypeMapper->replaceArgument(1, $types);
-        $containerFetcherTypeMapper->replaceArgument(2, $inputTypes);
-        $containerFetcherTypeMapper->replaceArgument(3, $typesByName);
-*/
 
         foreach ($typesNamespaces as $typesNamespace) {
             $definition = new Definition(GlobTypeMapper::class);
             $definition->addArgument($typesNamespace);
+            $definition->setArgument('$globTtl', $globTtl);
             $definition->setAutowired(true);
             $definition->addTag('graphql.type_mapper');
             $container->setDefinition('globTypeMapper_'.str_replace('\\', '__', $typesNamespace), $definition);
@@ -254,22 +184,6 @@ public static function createQueryProvider($controller, FieldsBuilderFactory $fi
         return new ControllerQueryProvider($controller, $fieldsBuilderFactory->buildFieldsBuilder($recursiveTypeMapper));
     }
 
-    /**
-     * @param string $typeClass
-     */
-    /*public static function createObjectType(string $typeClass, TypeGenerator $typeGenerator, RecursiveTypeMapperInterface $recursiveTypeMapper): MutableObjectType
-    {
-        return $typeGenerator->mapAnnotatedObject($typeClass, $recursiveTypeMapper);
-    }*/
-
-    /**
-     * @param object $factory
-     */
-    /*public static function createInputObjectType($factory, string $methodName, InputTypeGenerator $inputTypeGenerator, RecursiveTypeMapperInterface $recursiveTypeMapper): InputObjectType
-    {
-        return $inputTypeGenerator->mapFactoryMethod($factory, $methodName, $recursiveTypeMapper);
-    }*/
-
     /**
      * Returns a cached Doctrine annotation reader.
      * Note: we cannot get the annotation reader service in the container as we are in a compiler pass.