Switching "decider" key to "http_code_decider"

Refactoring code to remove setter.

Author: moufmouf

config/graphqlite.php

@@ -24,5 +24,5 @@
     'middleware' =>  ['web'],
 
     // Sets the status code in the HTTP request where operations have errors.
-    'decider' => HttpCodeDecider::class,
+    'http_code_decider' => HttpCodeDecider::class,
 ];

src/Controllers/GraphQLiteController.php

@@ -34,14 +34,14 @@ class GraphQLiteController
     /** @var bool|int */
     private $debug;
     /** @var HttpCodeDeciderInterface */
-    private $codeDecider;
+    private $httpCodeDecider;
 
-    public function __construct(StandardServer $standardServer, HttpMessageFactoryInterface $httpMessageFactory = null, ?int $debug = DebugFlag::RETHROW_UNSAFE_EXCEPTIONS)
+    public function __construct(StandardServer $standardServer, HttpCodeDeciderInterface $httpCodeDecider, HttpMessageFactoryInterface $httpMessageFactory = null, ?int $debug = DebugFlag::RETHROW_UNSAFE_EXCEPTIONS)
     {
         $this->standardServer = $standardServer;
+        $this->httpCodeDecider = $httpCodeDecider;
         $this->httpMessageFactory = $httpMessageFactory ?: new DiactorosFactory();
         $this->debug = $debug === null ? false : $debug;
-        $this->codeDecider = new HttpCodeDecider();
     }
 
     /**
@@ -77,7 +77,7 @@ private function handlePsr7Request(ServerRequestInterface $request): JsonRespons
     {
         $result = $this->standardServer->executePsrRequest($request);
 
-        $httpCodeDecider = $this->codeDecider;
+        $httpCodeDecider = $this->httpCodeDecider;
         if ($result instanceof ExecutionResult) {
             return new JsonResponse($result->toArray($this->debug), $httpCodeDecider->decideHttpStatusCode($result));
         }
@@ -95,9 +95,4 @@ private function handlePsr7Request(ServerRequestInterface $request): JsonRespons
         }
         throw new RuntimeException('Unexpected response from StandardServer::executePsrRequest'); // @codeCoverageIgnore
     }
-
-    public function setCodeDecider(HttpCodeDeciderInterface $decider): void
-    {
-        $this->codeDecider = $decider;
-    }
 }

src/Providers/GraphQLiteServiceProvider.php

@@ -20,6 +20,7 @@
 use TheCodingMachine\GraphQLite\Context\Context;
 use TheCodingMachine\GraphQLite\Exceptions\WebonyxErrorHandler;
 use TheCodingMachine\GraphQLite\Http\HttpCodeDecider;
+use TheCodingMachine\GraphQLite\Http\HttpCodeDeciderInterface;
 use TheCodingMachine\GraphQLite\Laravel\Listeners\CachePurger;
 use TheCodingMachine\GraphQLite\Laravel\Mappers\Parameters\ValidateFieldMiddleware;
 use TheCodingMachine\GraphQLite\Laravel\Mappers\PaginatorTypeMapper;
@@ -84,19 +85,22 @@ public function register()
         if (!$this->app->has(ResponseFactoryInterface::class)) {
             $this->app->bind(ResponseFactoryInterface::class, ResponseFactory::class);
         }
+        if (!$this->app->has(HttpCodeDeciderInterface::class)) {
+            $this->app->bind(HttpCodeDeciderInterface::class, HttpCodeDecider::class);
+        }
 
         $this->app->bind(HttpMessageFactoryInterface::class, PsrHttpFactory::class);
 
         $this->app->singleton(GraphQLiteController::class, function (Application $app) {
             $debug = config('graphqlite.debug', DebugFlag::RETHROW_UNSAFE_EXCEPTIONS);
-            $controller = new GraphQLiteController($app[StandardServer::class], $app[HttpMessageFactoryInterface::class], $debug);
-            $decider = config('graphqlite.decider');
-
-            if (!empty($decider)) {
-                $controller->setCodeDecider($app[$decider]);
+            $decider = config('graphqlite.http_code_decider');
+            if (!$decider) {
+                $httpCodeDecider = $app[HttpCodeDeciderInterface::class];
+            } else {
+                $httpCodeDecider = $app[$decider];
             }
 
-            return $controller;
+            return new GraphQLiteController($app[StandardServer::class], $httpCodeDecider, $app[HttpMessageFactoryInterface::class], $debug);
         });
 
         $this->app->singleton(StandardServer::class, static function (Application $app) {

tests/Providers/GraphQLiteServiceProviderTest.php

@@ -3,7 +3,7 @@
 namespace TheCodingMachine\GraphQLite\Laravel\Providers;
 
 
-use GraphQL\Error\Debug;
+use GraphQL\Error\DebugFlag;
 use GraphQL\Executor\ExecutionResult;
 use GraphQL\Server\StandardServer;
 use Orchestra\Testbench\TestCase;
@@ -180,8 +180,9 @@ public function testCachePurger(): void
      */
     public function testChangeTheCodeDecider()
     {
+        $this->app->instance(HttpCodeDeciderInterface::class, $this->newCodeDecider(418));
+
         $controller = $this->newGraphQLiteController();
-        $controller->setCodeDecider($this->newCodeDecider(418));
 
         $response = $controller->index($this->newRequest());
 
@@ -201,8 +202,9 @@ public function decideHttpStatusCode(ExecutionResult $result): int
     private function newGraphQLiteController(): GraphQLiteController
     {
         $server = $this->app->make(StandardServer::class);
+        $httpCodeDecider = $this->app->make(HttpCodeDeciderInterface::class);
         $messageFactory = $this->app->make(PsrHttpFactory::class);
-        return new GraphQLiteController($server, $messageFactory, Debug::RETHROW_UNSAFE_EXCEPTIONS);
+        return new GraphQLiteController($server, $httpCodeDecider, $messageFactory, DebugFlag::RETHROW_UNSAFE_EXCEPTIONS);
     }
 
     private function newRequest(): Request