Skip to content

Commit 0c29090

Browse files
authored
Improved description formatting for cost complexity (#618)
* Add new line for better description formatting * Updated tests * Use double quotes for proper \n parsing
1 parent d286d55 commit 0c29090

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/Middlewares/CostFieldMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function process(QueryFieldDescriptor $queryFieldDescriptor, FieldHandler
6363

6464
private function buildQueryComment(Cost $costAttribute): string
6565
{
66-
return 'Cost: ' .
66+
return "\nCost: " .
6767
implode(', ', [
6868
'complexity = ' . $costAttribute->complexity,
6969
'multipliers = [' . implode(', ', $costAttribute->multipliers) . ']',

tests/Integration/QueryComplexityTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public function testReportsQueryCostInIntrospection(string|null $expectedDescrip
175175
public static function reportsQueryCostInIntrospectionProvider(): iterable
176176
{
177177
yield [
178-
'Cost: complexity = 5, multipliers = [take], defaultMultiplier = 500',
178+
"\nCost: complexity = 5, multipliers = [take], defaultMultiplier = 500",
179179
'Query',
180180
'articles',
181181
];
@@ -187,15 +187,15 @@ public static function reportsQueryCostInIntrospectionProvider(): iterable
187187
];
188188

189189
yield [
190-
'Cost: complexity = 5, multipliers = [], defaultMultiplier = null',
190+
"\nCost: complexity = 5, multipliers = [], defaultMultiplier = null",
191191
'Post',
192192
'comment',
193193
];
194194

195195
yield [
196-
'Cost: complexity = 3, multipliers = [], defaultMultiplier = null',
196+
"\nCost: complexity = 3, multipliers = [], defaultMultiplier = null",
197197
'Post',
198198
'author',
199199
];
200200
}
201-
}
201+
}

tests/Middlewares/CostFieldMiddlewareTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,17 +109,17 @@ public function testAddsCostInDescription(string $expectedDescription, Cost $cos
109109
public static function addsCostInDescriptionProvider(): iterable
110110
{
111111
yield [
112-
'Cost: complexity = 1, multipliers = [], defaultMultiplier = null',
112+
"\nCost: complexity = 1, multipliers = [], defaultMultiplier = null",
113113
new Cost(),
114114
];
115115

116116
yield [
117-
'Cost: complexity = 5, multipliers = [take], defaultMultiplier = 500',
117+
"\nCost: complexity = 5, multipliers = [take], defaultMultiplier = 500",
118118
new Cost(complexity: 5, multipliers: ['take'], defaultMultiplier: 500)
119119
];
120120

121121
yield [
122-
'Cost: complexity = 5, multipliers = [take, null], defaultMultiplier = null',
122+
"\nCost: complexity = 5, multipliers = [take, null], defaultMultiplier = null",
123123
new Cost(complexity: 5, multipliers: ['take', 'null'], defaultMultiplier: null)
124124
];
125125
}

0 commit comments

Comments
 (0)